Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional public evaluate route #1351

Closed
WDaan opened this issue Feb 21, 2023 · 6 comments · Fixed by #1824
Closed

Optional public evaluate route #1351

WDaan opened this issue Feb 21, 2023 · 6 comments · Fixed by #1824
Assignees

Comments

@WDaan
Copy link

WDaan commented Feb 21, 2023

Problem

We would like to use Flipt as a general feature-flag service. So both frontend/backend services will want to evaluate their flags.
The management dashboard will be secured using SSO.

However, when you enable authentication, this is enabled for all routes...meaning no flags can be evaluated anymore without providing proper authentication. When using a static token, you immediately provide access to the whole CRUD api.

For a frontend project, we cannot simply set a static token on the frontend side so we would have to proxy all the requests and attach the token somewhere else.

Whole discussion can be read here

Ideal Solution

As mentioned in the discussion, a more granular token based auth system is on the roadmap, however we're not there yet.
The solution I propose for this kind of use-case is to create another setting that toggles public access to the evaluate-endpoint.

That way new flags can be securely created and managed using SSO and all services are allowed to evaluate their flags (which don't cause any risk).

example implementation

Let me know what you think.
Thanks!

@stale
Copy link

stale bot commented Mar 24, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 24, 2023
@stale stale bot closed this as completed Apr 7, 2023
@WDaan
Copy link
Author

WDaan commented Apr 7, 2023

Re-open?

@markphelps
Copy link
Collaborator

Yeah we def want to figure out a way to accomplish this that perhaps doesn't only limit to the evaluate / batch-evaluate routes. I can see people wanted to expose the GET Flag route publicly as well without auth

@markphelps markphelps reopened this Apr 13, 2023
@stale stale bot removed the stale label Apr 13, 2023
@stale
Copy link

stale bot commented May 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@markphelps
Copy link
Collaborator

FYI we are tackling this with the work done to solve #368

Should be out within the next two weeks or so for anyone interested to try. Will keep this issue updated as well

@WDaan
Copy link
Author

WDaan commented Jul 16, 2023

Awesome! Thanks for the great work so far and keeping this up to date :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants