feat(ext): add support for flag type and rollout definitions (#1826)

* test(ext): add failing cases for new version 1.1 and rollouts

* feat(ext): add support for flag type and rollout definitions

* fix(ext): adding missing error not-nil check

* test(readonly): bump testdata import version

* fix(ext): support rename from rollout percentage to threshold

* fix(ext): ensure minimum version enforced as expected

* test(readonly): update suite with boolean flag assertions

* feat(ext): support implicit rank in flag state version 1.1

* chore(ext): correct typos in comments

* fix(test/cli): update assertion for import/export

* feat(validate): add support for state version 1.1

* chore(build): address comment fix suggestions

* fix(test/migration): use an import file valid for latest

* fix(test/migration): import using latest build not tip

build/testing/cli.go

@@ -186,6 +186,7 @@ Use "flipt [command] --help" for more information about a command.
 	expectedFliptYAML = `flags:
 - key: zUFtS7D0UyMeueYu
   name: UAoZRksg94r1iipa
+  type: VARIANT_FLAG_TYPE
   description: description
   enabled: true
   variants:
@@ -194,7 +195,6 @@ Use "flipt [command] --help" for more information about a command.
   - key: sDGD6NvfCRyaQUn3
   rules:
   - segment: 08UoVJ96LhZblPEx
-    rank: 1
     distributions:
     - variant: NGxfcVffpMhBz9n8
       rollout: 100

build/testing/integration.go

@@ -253,7 +253,7 @@ func importExport(ctx context.Context, _ *dagger.Client, base, flipt *dagger.Con
 		if namespace == "" {
 			namespace = "default"
 			// replace namespace in expected yaml
-			expected = strings.ReplaceAll(expected, "version: \"1.0\"\n", fmt.Sprintf("version: \"1.0\"\nnamespace: %s\n", namespace))
+			expected = strings.ReplaceAll(expected, "version: \"1.1\"\n", fmt.Sprintf("version: \"1.1\"\nnamespace: %s\n", namespace))
 		}
 
 		// use target flipt binary to invoke import
@@ -272,7 +272,7 @@ func importExport(ctx context.Context, _ *dagger.Client, base, flipt *dagger.Con
 
 		diff := cmp.Diff(expected, generated)
 		if diff != "" {
-			fmt.Println("Unexpected difference in exported output:")
+			fmt.Printf("Unexpected difference in %q exported output: \n", conf.name)
 			fmt.Println(diff)
 			return errors.New("exported yaml did not match")
 		}

build/testing/integration/readonly/readonly_test.go

@@ -101,7 +101,7 @@ func TestReadOnly(t *testing.T) {
 				NamespaceKey: namespace,
 			})
 			require.NoError(t, err)
-			require.Len(t, flags.Flags, 51)
+			require.Len(t, flags.Flags, 52)
 
 			flag := flags.Flags[0]
 			assert.Equal(t, namespace, flag.NamespaceKey)
@@ -128,8 +128,8 @@ func TestReadOnly(t *testing.T) {
 					require.NoError(t, err)
 
 					if flags.NextPageToken == "" {
-						// ensure last page contains 1 entry
-						assert.Len(t, flags.Flags, 1)
+						// ensure last page contains 2 entries (boolean and disabled)
+						assert.Len(t, flags.Flags, 2)
 
 						found = append(found, flags.Flags...)
 
@@ -144,7 +144,7 @@ func TestReadOnly(t *testing.T) {
 					nextPage = flags.NextPageToken
 				}
 
-				require.Len(t, found, 51)
+				require.Len(t, found, 52)
 			})
 		})