Skip to content

Commit

Permalink
chore(tests): add unit tests for delete in the middleware
Browse files Browse the repository at this point in the history
  • Loading branch information
yquansah committed Jul 7, 2023
1 parent d5310e6 commit 5b03535
Show file tree
Hide file tree
Showing 2 changed files with 39 additions and 1 deletion.
2 changes: 1 addition & 1 deletion internal/server/audit/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ type RolloutThreshold struct {
}

type RolloutSegment struct {
Key string `json:"Key"`
Key string `json:"key"`
Value bool `json:"value"`
}

Expand Down
38 changes: 38 additions & 0 deletions internal/server/middleware/grpc/middleware_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1513,6 +1513,44 @@ func TestAuditUnaryInterceptor_UpdateRollout(t *testing.T) {
assert.Equal(t, 1, exporterSpy.GetSendAuditsCalled())
}

func TestAuditUnaryInterceptor_DeleteRollout(t *testing.T) {
var (
store = &storeMock{}
logger = zaptest.NewLogger(t)
exporterSpy = newAuditExporterSpy(logger)
s = server.New(logger, store)
req = &flipt.DeleteRolloutRequest{
Id: "1",
FlagKey: "flagKey",
}
)

store.On("DeleteRollout", mock.Anything, req).Return(nil)

unaryInterceptor := AuditUnaryInterceptor(logger)

handler := func(ctx context.Context, r interface{}) (interface{}, error) {
return s.DeleteRollout(ctx, r.(*flipt.DeleteRolloutRequest))
}

info := &grpc.UnaryServerInfo{
FullMethod: "DeleteRollout",
}

tp := sdktrace.NewTracerProvider(sdktrace.WithSampler(sdktrace.AlwaysSample()))
tp.RegisterSpanProcessor(sdktrace.NewSimpleSpanProcessor(exporterSpy))

tr := tp.Tracer("SpanProcessor")
ctx, span := tr.Start(context.Background(), "OnStart")

got, err := unaryInterceptor(ctx, req, info, handler)
require.NoError(t, err)
assert.NotNil(t, got)

span.End()
assert.Equal(t, 1, exporterSpy.GetSendAuditsCalled())
}

func TestAuditUnaryInterceptor_CreateRule(t *testing.T) {
var (
store = &storeMock{}
Expand Down

0 comments on commit 5b03535

Please sign in to comment.