From 38604aca025ac5eb207193afbde1ab85b2a5b9e5 Mon Sep 17 00:00:00 2001
From: Yoofi Quansah <ybquansah@gmail.com>
Date: Mon, 3 Jul 2023 09:42:42 -0500
Subject: [PATCH] chore: add tests for coverage

---
 internal/server/evaluation/evaluator_test.go | 144 +++++++++++++++++++
 1 file changed, 144 insertions(+)

diff --git a/internal/server/evaluation/evaluator_test.go b/internal/server/evaluation/evaluator_test.go
index 5bc9f535bc..902fb93d0e 100644
--- a/internal/server/evaluation/evaluator_test.go
+++ b/internal/server/evaluation/evaluator_test.go
@@ -896,6 +896,87 @@ func TestEvaluator_RulesOutOfOrder(t *testing.T) {
 	assert.Equal(t, flipt.EvaluationReason_ERROR_EVALUATION_REASON, resp.Reason)
 }
 
+func TestEvaluator_ErrorParsingNumber(t *testing.T) {
+	var (
+		store  = &evaluationStoreMock{}
+		logger = zaptest.NewLogger(t)
+		s      = NewEvaluator(logger, store)
+	)
+
+	store.On("GetEvaluationRules", mock.Anything, mock.Anything, "foo").Return(
+		[]*storage.EvaluationRule{
+			{
+				ID:               "1",
+				FlagKey:          "foo",
+				SegmentKey:       "bar",
+				SegmentMatchType: flipt.MatchType_ALL_MATCH_TYPE,
+				Rank:             1,
+				Constraints: []storage.EvaluationConstraint{
+					{
+						ID:       "2",
+						Type:     flipt.ComparisonType_NUMBER_COMPARISON_TYPE,
+						Property: "bar",
+						Operator: flipt.OpEQ,
+						Value:    "boz",
+					},
+				},
+			},
+		}, nil)
+
+	resp, err := s.Evaluate(context.TODO(), enabledFlag, &flipt.EvaluationRequest{
+		EntityId: "1",
+		FlagKey:  "foo",
+		Context: map[string]string{
+			"bar": "baz",
+		},
+	})
+
+	assert.Error(t, err)
+	assert.EqualError(t, err, "parsing number from \"baz\"")
+	assert.False(t, resp.Match)
+	assert.Equal(t, flipt.EvaluationReason_ERROR_EVALUATION_REASON, resp.Reason)
+}
+func TestEvaluator_ErrorParsingDateTime(t *testing.T) {
+	var (
+		store  = &evaluationStoreMock{}
+		logger = zaptest.NewLogger(t)
+		s      = NewEvaluator(logger, store)
+	)
+
+	store.On("GetEvaluationRules", mock.Anything, mock.Anything, "foo").Return(
+		[]*storage.EvaluationRule{
+			{
+				ID:               "1",
+				FlagKey:          "foo",
+				SegmentKey:       "bar",
+				SegmentMatchType: flipt.MatchType_ALL_MATCH_TYPE,
+				Rank:             1,
+				Constraints: []storage.EvaluationConstraint{
+					{
+						ID:       "2",
+						Type:     flipt.ComparisonType_DATETIME_COMPARISON_TYPE,
+						Property: "bar",
+						Operator: flipt.OpEQ,
+						Value:    "boz",
+					},
+				},
+			},
+		}, nil)
+
+	resp, err := s.Evaluate(context.TODO(), enabledFlag, &flipt.EvaluationRequest{
+		EntityId: "1",
+		FlagKey:  "foo",
+		Context: map[string]string{
+			"bar": "baz",
+		},
+	})
+
+	assert.Error(t, err)
+	assert.EqualError(t, err, "parsing datetime from \"baz\"")
+	assert.False(t, resp.Match)
+	assert.Equal(t, flipt.EvaluationReason_ERROR_EVALUATION_REASON, resp.Reason)
+}
+
 func TestEvaluator_ErrorGettingDistributions(t *testing.T) {
 	var (
 		store  = &evaluationStoreMock{}
@@ -1023,6 +1104,69 @@ func TestEvaluator_MatchAll_NoVariants_NoDistributions(t *testing.T) {
 	}
 }
 
+func TestEvaluator_DistributionNotMatched(t *testing.T) {
+	var (
+		store  = &evaluationStoreMock{}
+		logger = zaptest.NewLogger(t)
+		s      = NewEvaluator(logger, store)
+	)
+
+	store.On("GetEvaluationRules", mock.Anything, mock.Anything, "foo").Return(
+		[]*storage.EvaluationRule{
+			{
+				ID:               "1",
+				FlagKey:          "foo",
+				SegmentKey:       "bar",
+				SegmentMatchType: flipt.MatchType_ALL_MATCH_TYPE,
+				Rank:             0,
+				Constraints: []storage.EvaluationConstraint{
+					// constraint: bar (string) == baz
+					{
+						ID:       "2",
+						Type:     flipt.ComparisonType_STRING_COMPARISON_TYPE,
+						Property: "bar",
+						Operator: flipt.OpEQ,
+						Value:    "baz",
+					},
+					// constraint: admin (bool) == true
+					{
+						ID:       "3",
+						Type:     flipt.ComparisonType_BOOLEAN_COMPARISON_TYPE,
+						Property: "admin",
+						Operator: flipt.OpTrue,
+					},
+				},
+			},
+		}, nil)
+
+	store.On("GetEvaluationDistributions", mock.Anything, "1").Return(
+		[]*storage.EvaluationDistribution{
+			{
+				ID:                "4",
+				RuleID:            "1",
+				VariantID:         "5",
+				Rollout:           10,
+				VariantKey:        "boz",
+				VariantAttachment: `{"key":"value"}`,
+			},
+		}, nil)
+
+	resp, err := s.Evaluate(context.TODO(), enabledFlag, &flipt.EvaluationRequest{
+		FlagKey:  "foo",
+		EntityId: "123",
+		Context: map[string]string{
+			"bar":   "baz",
+			"admin": "true",
+		},
+	})
+
+	assert.NoError(t, err)
+	assert.NotNil(t, resp)
+	assert.Equal(t, "foo", resp.FlagKey)
+
+	assert.False(t, resp.Match, "distribution not matched")
+}
+
 func TestEvaluator_MatchAll_SingleVariantDistribution(t *testing.T) {
 	var (
 		store  = &evaluationStoreMock{}