-
-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added glow effect using maskFilter #2129
Conversation
How do I change the size and color of the glow effect? Glow is supposed to be like a neon light, right? |
Screen.Recording.2022-10-28.at.10.02.01.PM.movScreen.Recording.2022-10-28.at.10.19.04.PM.mov |
Awesome! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice addition!
But it seems like this needs to have a well-considered documentation. For example, the effect applies to shapes but not sprites. It makes a certain paint glow -- so the component has to be drawing something with a paint. We need to investigate how it would apply to "stroke" paints, or to transparent paints (say, can I draw a transparent outline of a sprite and make that outline glow?)
blurValue renamed to strength. removed unused var.
example on stroke paints Screen.Recording.2022-10-29.at.9.09.28.AM.mov |
example on outline. Screen.Recording.2022-10-29.at.9.24.47.AM.mov |
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
There should also be tests and docs for it (with an interactive example), but other than that it looks good! |
Screen.Recording.2022-10-29.at.4.25.12.PM.mov |
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
Oh lol -- I just realized that this filter replaces the color with a glow. So if you had a shape with a solid color before, that color will now disappear and there will only be glow. Perhaps we could mark this effect as |
if we use |
Yeah, but it would hardly look like a glow then -- more like a blurred-out shape. |
We should make the effect target a color then right? So that the component can have several colors defined. |
I guess the first thing we have to acknowledge is that "glow effect" is not an |
Maybe it could be modified to be pulsating or such? But yeah, maybe this shouldn't have been an effect at all. |
Description
A new paint effect for glowing effects using maskFilter.
Checklist
fix:
,feat:
,docs:
etc).docs
and added dartdoc comments with///
.examples
ordocs
.Breaking Change?
Related Issues
Closes #1027