feat: quad tree broadphase support #1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spydon
reviewed
Sep 9, 2022
packages/flame/lib/src/collisions/quadtree/quadtree_collision_detection.dart
Outdated
Show resolved
Hide resolved
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
|
I have done with tests - looks like old tests are reused correctly 🎉 |
spydon
approved these changes
Sep 23, 2022
packages/flame/lib/src/collisions/quadtree/has_quadtree_collision_detection.dart
Outdated
Show resolved
Hide resolved
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
# Conflicts: # packages/flame/test/collisions/collision_callback_test.dart
spydon
approved these changes
Sep 25, 2022
wolfenrain
approved these changes
Sep 27, 2022
|
@ASGAlex if you can just fix the merge conflict this PR is ready to be merged! 😍 |
|
15 minutes 👌 |
# Conflicts: # packages/flame/test/collisions/collision_callback_test.dart
auto-merge was automatically disabled
September 27, 2022 11:39
Head branch was pushed to by a user without write access
|
@spydon looks like done =^_^= |
Great job! I think it ended up quite nice :) |
|
@ASGAlex congrats! You did great job! :) |
7 tasks
spydon
pushed a commit
that referenced
this pull request
Sep 27, 2022
…1943) A variant of refactoring mentioned here #1894 (comment) Sweep broadphase have no any additional specific classes, it's based only on core classes. So it is discussion question, do we need to keep int in separate folder (to avoid mixing with core broadphase.dart file) or just leave it in the root folder 'broadphase'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Quad tree broadphase support.
Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examples.Breaking Change