feat: Allow children of ComposedParticle
to have varied lifespan
#1879
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Existing behavior:
ComposedParticle
takeslifespan
andchildren
as a constructor argument. At the construction timelifespan
is propagated to all child particles.New behavior:
ComposedParticle
has an extra optional parameterapplyLifespanToChildren
. If set totrue
then existing behavior is preserved and all child particles will be assigned the lifespan ofComposedParticle
, if set tofalse
child particles will keep their original lifespan. If a particle lifecycle ends beforeComposedParticle
ends then it is removed from children.applyLifespanToChildren
is set totrue
by default for backward compatibility.Please note, that this is a proposal. I will update the docs and examples if the approach is approved.Breaking Change
[x] No, this is not a breaking change.
Checklist
fix:
,feat:
,docs:
etc).docs
and added dartdoc comments with///
.examples
.Related Issues
#1872