Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Overlays can now be properly added during onLoad #1759

Merged
merged 2 commits into from
Jun 29, 2022

Conversation

st-pasha
Copy link
Contributor

Description

The problem was that the variable _ActiveOverlays._game was assigned too late, and as a result the request to refresh the widget was silently dropped.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • [-] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • [-] I have updated/added relevant examples in examples.

Breaking Change

  • [-] Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

Closes #1757

@spydon spydon requested a review from a team June 29, 2022 06:04
@erickzanardo erickzanardo merged commit 9f35b15 into flame-engine:main Jun 29, 2022
@st-pasha st-pasha deleted the ps.overlay-in-onload branch June 29, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overlays not shown after Flame 1.2.0 Update
4 participants