-
-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Dispose TextBoxComponent
image cache properly
#1579
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spydon
requested review from
luanpotter,
erickzanardo,
renancaraujo and
wolfenrain
April 26, 2022 20:16
wolfenrain
approved these changes
Apr 26, 2022
erickzanardo
approved these changes
Apr 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, but LGTM already
Co-authored-by: Erick <erickzanardoo@gmail.com>
st-pasha
reviewed
Apr 27, 2022
st-pasha
reviewed
Apr 27, 2022
I think there's still a possibility of a leak here if I believe the following version of Future<void> redraw() async {
final newSize = _recomputeSize();
final image = await _fullRenderAsImage(newSize);
cache?.dispose();
cache = image;
size = newSize;
} |
Co-authored-by: Pasha Stetsenko <stpasha@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since we didn't dispose of the
Image
object that was used as a cache inTextBoxComponent
we had a memory leak.Side note: I wonder if it is really worth using
PictureRecorder
in that class.Checklist
fix:
,feat:
,docs:
etc).docs
and added dartdoc comments with///
.examples
.Breaking Change
Related Issues
Fixes: #1462