Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad method summaries derived for complex flow #85

Closed
formanek opened this issue Sep 11, 2015 · 0 comments
Closed

Bad method summaries derived for complex flow #85

formanek opened this issue Sep 11, 2015 · 0 comments
Labels
Milestone

Comments

@formanek
Copy link
Contributor

Because of the direct Taint instances modifications, the Taint class had its equals method defined only for the state attribute - full equals caused an error from the issue #82. For this reason, the analysis sometimes finished too early (with less iterations than actually needed) and some parameter was missing in the summary or non-parametric taint was invalid. Although this affected less than 1% of method summaries, it could cause both false positives and false negatives. This is fixed by not modifying values in frames directly and implementing proper equals method for Taint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants