Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from keytar to Electron's safeStorage API. #1656

Open
bajtos opened this issue Jun 28, 2024 · 0 comments
Open

Move from keytar to Electron's safeStorage API. #1656

bajtos opened this issue Jun 28, 2024 · 0 comments

Comments

@bajtos
Copy link
Member

bajtos commented Jun 28, 2024

keytar is no longer maintained as of Dec 2022, see atom/node-keytar#482.

Other projects like VS Code solved the problem by moving to Electron's safeStorage API, see https://code.visualstudio.com/updates/v1_80#_secretstorage-api-now-uses-electron-api-over-keytar

We should follow their lead and to the same.

Example pull request for inspiration: jfrog/jfrog-vscode-extension#417

We must be extra careful when implementing this change, since we use keytar to store the wallet seed. If we mess this up, the user won't have access to their wallet & rewards earned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant