Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tech Debt] Clean up fetch content with fallback #40

Open
AmeanAsad opened this issue Nov 3, 2023 · 0 comments
Open

[Tech Debt] Clean up fetch content with fallback #40

AmeanAsad opened this issue Nov 3, 2023 · 0 comments
Assignees
@AmeanAsad

Comments

@AmeanAsad
Copy link
Contributor

AmeanAsad commented Nov 3, 2023 •
edited
Loading

  • fetchContentWithFallback as 3 different fetching blocks that can be combined into 1.
  • We should create an async generator that yields the nodes. It would yield the CDN url then await the nodes list being loaded, then add the customer fallback origin in the end. That way we can combine the fetch blocks into 1 and iterate the nodes list without having to modify it mid loop.
@AmeanAsad AmeanAsad changed the title [Tech DebtClean up fetch content with fallback [Tech Debt] Clean up fetch content with fallback Nov 3, 2023
@AmeanAsad AmeanAsad self-assigned this Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AmeanAsad AmeanAsad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AmeanAsad