Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parent controller functionality to fetchCidWithRace #34

Open
AmeanAsad opened this issue Oct 30, 2023 · 0 comments
Open

Add parent controller functionality to fetchCidWithRace #34

AmeanAsad opened this issue Oct 30, 2023 · 0 comments
Assignees

Comments

@AmeanAsad
Copy link
Contributor

Description

  • Currently, fetchCid is able to accept an external controller to use for making requests. That allows the client making the request to abort it on its own terms (custom timeout, data size limit, etc.)
  • fetchCidWithRace doesn't currently support that. It adds a layer of complexity because it races multiple nodes, and therefore requires multiple controllers.

Rough Approach:

  • the ideal approach here is to have a hierarchy over controllers. The client is able to pass a controller that kills all the controllers being used in the fetches but we should still have the ability to abort each request indepedently using its own controller.
@AmeanAsad AmeanAsad self-assigned this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant