Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Undesired?) leading whitespace in music.band #3011

Closed
JeremasPosta opened this issue Oct 15, 2024 · 1 comment · Fixed by #3015
Closed

(Undesired?) leading whitespace in music.band #3011

JeremasPosta opened this issue Oct 15, 2024 · 1 comment · Fixed by #3015

Comments

@JeremasPosta
Copy link
Contributor

JeremasPosta commented Oct 15, 2024

Describe the bug

Hi all.

Just came upon a flaky test on our app because of this music.band starting with an empty space.
Not your fault at all, but happy to open a PR for updating it if you are good with that.


I did git-blame this file and I don't think this was purposely added so long ago.

To Reproduce

Just use Faker::Music.band

1000.times{band = Faker::Music.band; puts band if band.starts_with?(' ')}
 The
 The
 The
 The
 The
=> 1000

Expected behavior

I would not expect to have just ONE example breaking the convention.

Additional context

Proposed fix:

  • Just remove that one
@thdaraujo
Copy link
Contributor

oh that's funny. Yeah, feel free to send a PR and I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants