You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
.github/workflows/docker.yml - This file contains build commands for docker without pushing to the docker hub. The build works when creating ANY PR (it is not correct, it should be triggered only for development and master). Some parameters have typos ("NEXT_PUBLIC_BLOCKCHAIN_INFO=blockchanin"). It looks like the docker build is not needed and is not used. We also have a docker hub that hasn't had any project updates for 5 months: https://hub.docker.com/r/fairdatasociety/fairdrive. Do you think we need this action? @darkobas2
.github/workflows/swarm.yml and .github/workflows/node.js.yml - these 2 actions run simultaneously. node.js.yml doesn't make sense at the moment, as it only builds the project and nothing else happens to the build. swarm.yml builds the project and uploads it to swarm. It is worth transforming node.js.yml so that it runs tests and checks the correctness of the code with a linter. And only after successfully passing the tests and the linter, swarm.yml should be launched.
Sequential launch of actions can be done using the workflow_run event.
The text was updated successfully, but these errors were encountered:
It was added because there were a lot of pushes which ended up not beeing able to build in a clean env either because of production flags or module caching. So idea is that this is a general check if the code builds from scratch, with production flags and without cached modules.
.github/workflows/docker.yml
- This file contains build commands for docker without pushing to the docker hub. The build works when creating ANY PR (it is not correct, it should be triggered only for development and master). Some parameters have typos ("NEXT_PUBLIC_BLOCKCHAIN_INFO=blockchanin"). It looks like the docker build is not needed and is not used. We also have a docker hub that hasn't had any project updates for 5 months: https://hub.docker.com/r/fairdatasociety/fairdrive. Do you think we need this action? @darkobas2.github/workflows/swarm.yml
and.github/workflows/node.js.yml
- these 2 actions run simultaneously.node.js.yml
doesn't make sense at the moment, as it only builds the project and nothing else happens to the build.swarm.yml
builds the project and uploads it to swarm. It is worth transformingnode.js.yml
so that it runs tests and checks the correctness of the code with a linter. And only after successfully passing the tests and the linter,swarm.yml
should be launched.Sequential launch of actions can be done using the
workflow_run
event.The text was updated successfully, but these errors were encountered: