{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":289978759,"defaultBranch":"main","name":"Glean","ownerLogin":"facebookincubator","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2020-08-24T16:20:38.000Z","ownerAvatar":"https://github.com/avatars/u/19538647?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1720675858.0","currentOid":""},"activityList":{"items":[{"before":"4046373a9c1c80e8f7a1d0ffa8686559f364251a","after":"5d1f21a0d4ae13237a31d7fd5b6e83c0b6b6b780","ref":"refs/heads/main","pushedAt":"2024-09-13T19:48:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"complete migration to TypeInfo\n\nSummary:\nThere are two type predicates in the Hack schema.\n\nThe legacy, deprecated, `type`, and the most recent `TypeInfo`.\n\n`TypeInfo` contains the pretty-printed type, but also xrefs relative to that string. Codehub uses it to generate go-to-def links the API doc page.\n\nNot all definitions contain a TypeInfo field yet. This diff updates the schema to add it everywhere.\n\nMotivation:\n - consistency\n - if we want to index the Hack type AST, it'll be simpler to add a new field in TypeInfo, which is now available everywhere (see linked task)\n\nReviewed By: pepeiborra, donsbot\n\nDifferential Revision: D62471296\n\nfbshipit-source-id: 17bf41cab000600d294058b9a3c4293c4504ecd2","shortMessageHtmlLink":"complete migration to TypeInfo"}},{"before":"7c49b3e7fe7639e86697ba29ca16ad606a9ec972","after":"4046373a9c1c80e8f7a1d0ffa8686559f364251a","ref":"refs/heads/main","pushedAt":"2024-09-13T19:21:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Add .pyi files in glass mapping\n\nSummary:\nCurrently, we don't provide any navigation info for .pyi files because glass doesn't return any meaningful symbol data\n\n````\n$  glass symbol-index fbsource/fbcode/servicerouter/client/py3lite/client_params.pyi\nfbsource/fbcode/servicerouter/client/py3lite/client_params.pyi 0:fbsource/buck/f/fbcode/servicerouter/client/py3lite/client_params.pyi\n````\n\nThe reason seems to be that it is looking information in a buck db instead of the fbcode python db\n\n> fbsource/fbcode/servicerouter/client/py3lite/client_params.pyi  0:**fbsource/buck**/f/fbcode/servicerouter/client/py3lite/client_params.pyi\n\nReviewed By: iamirzhan\n\nDifferential Revision: D62643899\n\nfbshipit-source-id: a4a0b2c024becee0a4355c3a9b069f462a361f7f","shortMessageHtmlLink":"Add .pyi files in glass mapping"}},{"before":"e32da7c662a08d294fe29905945112c026674c65","after":"7c49b3e7fe7639e86697ba29ca16ad606a9ec972","ref":"refs/heads/main","pushedAt":"2024-09-13T09:58:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Fix the Haskell indexer again\n\nSummary:\nNow we switched Glean to GHC 9.2.4, we have to override the GHC\nversion to build the Haskell indexer so we can continue to index with\n8.8.3.\n\nReviewed By: donsbot\n\nDifferential Revision: D62580324\n\nfbshipit-source-id: 686d0a5ea9b4a94499cbdad7639fc9ff091ae744","shortMessageHtmlLink":"Fix the Haskell indexer again"}},{"before":"11882f1df605b6bfb46a8963e9ce537aeb3dee49","after":"e32da7c662a08d294fe29905945112c026674c65","ref":"refs/heads/main","pushedAt":"2024-09-12T16:25:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Fix spelling in license header\n\nReviewed By: pepeiborra\n\nDifferential Revision: D62580120\n\nfbshipit-source-id: 5161bf781dd02ce4dc61dd75632fd1ddc85b4e07","shortMessageHtmlLink":"Fix spelling in license header"}},{"before":"f36752e755e5535dff667391439148e1ca0da109","after":"11882f1df605b6bfb46a8963e9ce537aeb3dee49","ref":"refs/heads/main","pushedAt":"2024-09-12T14:15:55.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Use unsafeWithForeignPtr\n\nReviewed By: josefs\n\nDifferential Revision: D62376091\n\nfbshipit-source-id: 1d788a9e4b5700159776da57b7b63d4246b009ab","shortMessageHtmlLink":"Use unsafeWithForeignPtr"}},{"before":"a1f4a7e2eaa0bebc34c455d7e5c921c1869a32c2","after":"f36752e755e5535dff667391439148e1ca0da109","ref":"refs/heads/main","pushedAt":"2024-09-12T14:03:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Refactoring\n\nSummary:\nIntroduce an enum `RecordOrSum` and use it instead of `Bool` in a\ncouple of places.\n\nReviewed By: josefs\n\nDifferential Revision: D62503588\n\nfbshipit-source-id: 7003c86d8e55927c1e085de1997b296bc1bdf7a1","shortMessageHtmlLink":"Refactoring"}},{"before":"52b2d6c09eec5be7cbd0e03f6f541b35e5e2ff0c","after":"a1f4a7e2eaa0bebc34c455d7e5c921c1869a32c2","ref":"refs/heads/main","pushedAt":"2024-09-12T01:54:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Remove @thrift.AllowReservedIdentifierName and the compiler validations that use it\n\nSummary: Remove thrift.AllowReservedIdentifierName and the compiler validations that use it.\n\nReviewed By: vitaut\n\nDifferential Revision: D62475525\n\nfbshipit-source-id: 333961233a9ca6df5cb46791145f74724c1e1870","shortMessageHtmlLink":"Remove @thrift.AllowReservedIdentifierName and the compiler validatio…"}},{"before":"0ba07deb65220fbe20204ed25c5e655e60aae61f","after":"52b2d6c09eec5be7cbd0e03f6f541b35e5e2ff0c","ref":"refs/heads/main","pushedAt":"2024-09-11T19:53:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Improve pretty printing for HasTy\n\nSummary:\nBefore:\n\n```\nwww.hack.light> cxx1.FunctionDeclaration F where F.name.name.name = \"memcpy\"\ntype error:\n  { name : T7 ...6}\ndoes not match:\n  {\n    name : cxx1.Name.5 |\n    operator_ : cxx1.Operator.5 |\n    literalOperator : cxx1.LiteralOperator.5 |\n    constructor : builtin.Unit.1 |\n    destructor : builtin.Unit.1 |\n    conversionOperator : cxx1.Type.5 |\n  }\n\n1 |  cxx1.FunctionDeclaration F where F.name.name.name = \"memcpy\"\n                                      ^^^^^^^^^^^^^^^^\nwww.hack.light> cxx1.FunctionDeclaration F where F.name?.name.name = \"memcpy\"\ntype error:\n  { name : T3 ...2}\ndoes not match:\n  {\n    name : cxx1.FunctionQName.5,\n    signature : cxx1.Signature.5,\n    method : (maybe cxx1.MethodSignature.5),\n    source : src.Range.1\n  }\n\n1 |  cxx1.FunctionDeclaration F where F.name?.name.name = \"memcpy\"\n                                      ^^^^^^^\n```\n\nAfter\n\n```\nwww.hack.light> cxx1.FunctionDeclaration F where F.name.name.name = \"memcpy\"\ntype error:\n  { name : T7, T6 }\ndoes not match:\n  {\n    name : cxx1.Name.5 |\n    operator_ : cxx1.Operator.5 |\n    literalOperator : cxx1.LiteralOperator.5 |\n    constructor : builtin.Unit.1 |\n    destructor : builtin.Unit.1 |\n    conversionOperator : cxx1.Type.5 |\n  }\n\n1 |  cxx1.FunctionDeclaration F where F.name.name.name = \"memcpy\"\n                                      ^^^^^^^^^^^^^^^^\nwww.hack.light> cxx1.FunctionDeclaration F where F.name?.name.name = \"memcpy\"\ntype error:\n  { name : T3 | T2 }\ndoes not match:\n  {\n    name : cxx1.FunctionQName.5,\n    signature : cxx1.Signature.5,\n    method : (maybe cxx1.MethodSignature.5),\n    source : src.Range.1\n  }\n\n1 |  cxx1.FunctionDeclaration F where F.name?.name.name = \"memcpy\"\n                                      ^^^^^^^\n```\n\nReviewed By: josefs\n\nDifferential Revision: D62502237\n\nfbshipit-source-id: 1aa556003ca8af6b425cd46d188d2bf4fd3150a5","shortMessageHtmlLink":"Improve pretty printing for HasTy"}},{"before":"4c3fd7b9c3312d248b6958c67327115143d96583","after":"0ba07deb65220fbe20204ed25c5e655e60aae61f","ref":"refs/heads/main","pushedAt":"2024-09-11T17:45:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Infer the left-hand-side of dot\n\nSummary:\nThis example should work:\n\n```\ncxx1.RecordDeclaration R where R.name.name = \"vector\"\n```\n\nbut it currently fails because the type of R is not known at the time\nwe typecheck `R.name`.  This diff fills in the missing inference\nfunctionality. It required adding the ability to \"demote\" an\nexpression from a predicate type to its key type, which is the dual of\nthe \"promote\" operator we already had.\n\nWith this change I'm happy enough with dot syntax that I think we can\nadvertise it more widely.\n\nReviewed By: josefs\n\nDifferential Revision: D62499221\n\nfbshipit-source-id: c1eec9af52457c9b246d3794df3a501955333ec4","shortMessageHtmlLink":"Infer the left-hand-side of dot"}},{"before":"5962ff760d3a36d3e9e4f4dcbef10f5c6bd7c7e0","after":"be26823c26573b067b2624f8051dd83aa6c07cdf","ref":"refs/heads/gh-pages","pushedAt":"2024-09-11T16:17:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://github.com/avatars/in/15368?s=80&v=4"},"commit":{"message":"Deploying to gh-pages from  @ 4c3fd7b9c3312d248b6958c67327115143d96583 🚀","shortMessageHtmlLink":"Deploying to gh-pages from @ <a class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/facebookincubator/Glean/commit/4c3fd7b9c3312d248b6958c67327115143d96583/hovercard\" href=\"https://github.com/facebookincubator/Glean/commit/4c3fd7b9c3312d248b6958c67327115143d96583\"><tt>4c3fd7b</tt></a> 🚀"}},{"before":"5782bc1e3e2351b416d867d30b72035cc017fae5","after":"4c3fd7b9c3312d248b6958c67327115143d96583","ref":"refs/heads/main","pushedAt":"2024-09-11T16:15:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Fix website links to be OSS compliant\n\nReviewed By: bochko\n\nDifferential Revision: D62501292\n\nfbshipit-source-id: 1aa714d611cc16b68721bcda04857369b3065899","shortMessageHtmlLink":"Fix website links to be OSS compliant"}},{"before":"b67490b4c56f4925f082a9a9a0664c0105a77151","after":"5782bc1e3e2351b416d867d30b72035cc017fae5","ref":"refs/heads/main","pushedAt":"2024-09-11T15:41:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Fix some license headers\n\nReviewed By: phlalx\n\nDifferential Revision: D62441538\n\nfbshipit-source-id: dacf50371550c8099c1a1ef304c53fcb1a66e1c8","shortMessageHtmlLink":"Fix some license headers"}},{"before":"fa9d2ab338ee85c8199babe4e77082692f883d94","after":"b67490b4c56f4925f082a9a9a0664c0105a77151","ref":"refs/heads/main","pushedAt":"2024-09-11T09:58:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Fix the Haskell indexer\n\nSummary:\nWe have to explicitly force 8.8.3 for now. This depends on the new\n`modifiers` flag to `configured_targets()` added in D62107364\n\nReviewed By: pepeiborra\n\nDifferential Revision: D62487850\n\nfbshipit-source-id: 3a357fd4ccea4fdd80e52a8e4c6566854ada8413","shortMessageHtmlLink":"Fix the Haskell indexer"}},{"before":"cb5621030a53c16c6a9fe89c9f6c41ca55a7e58d","after":"fa9d2ab338ee85c8199babe4e77082692f883d94","ref":"refs/heads/main","pushedAt":"2024-09-11T08:20:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Represent sets as std::set<folly::fbstring>\n\nSummary:\nThis diff sets the runtime representation of sets in Angle. I'm using `std::set` since I want to be able to sort the elements lexicographically and be able to fetch them in a deterministic way.\n\nUsing `folly::fbstring`  to represent the bytestrings, as suggested in the comments.\n\nReviewed By: bochko, simonmar\n\nDifferential Revision: D60456191\n\nfbshipit-source-id: 65fb5177d1ce65fa65c26d315c11a6e73bf756df","shortMessageHtmlLink":"Represent sets as std::set&lt;folly::fbstring&gt;"}},{"before":"e2349da63faa5e27ff43b39f663224e2ac331f40","after":"cb5621030a53c16c6a9fe89c9f6c41ca55a7e58d","ref":"refs/heads/main","pushedAt":"2024-09-10T20:59:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"move more instances of `fbsource` -> `full-fbsource`\n\nSummary: Drive by fixes.\n\nReviewed By: Sushisugre\n\nDifferential Revision: D62450575\n\nfbshipit-source-id: e84a48ae13d123f18e72e412df43a27bb6e84378","shortMessageHtmlLink":"move more instances of <code>fbsource</code> -&gt; <code>full-fbsource</code>"}},{"before":"8d71e994f11bf82cffd988d3f6294006f91e6941","after":"e2349da63faa5e27ff43b39f663224e2ac331f40","ref":"refs/heads/main","pushedAt":"2024-09-10T10:00:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"redo codemarkup haskell tests\n\nSummary: These tests were using a precomputed hiedb as the test source. Migrated them to use the `glean/lang/haskell/tests/code` as the test source and generate the hiedb dynamically at test runtime\n\nReviewed By: malanka\n\nDifferential Revision: D62429900\n\nfbshipit-source-id: 9138a82d9b7429028263f81986314c66b200b503","shortMessageHtmlLink":"redo codemarkup haskell tests"}},{"before":"732c96412ca45904c1f8ce95b8e7bb89e98ad947","after":"5962ff760d3a36d3e9e4f4dcbef10f5c6bd7c7e0","ref":"refs/heads/gh-pages","pushedAt":"2024-09-06T15:24:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://github.com/avatars/in/15368?s=80&v=4"},"commit":{"message":"Deploying to gh-pages from  @ 8d71e994f11bf82cffd988d3f6294006f91e6941 🚀","shortMessageHtmlLink":"Deploying to gh-pages from @ <a class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/facebookincubator/Glean/commit/8d71e994f11bf82cffd988d3f6294006f91e6941/hovercard\" href=\"https://github.com/facebookincubator/Glean/commit/8d71e994f11bf82cffd988d3f6294006f91e6941\"><tt>8d71e99</tt></a> 🚀"}},{"before":"c0f64b6b3a4258ef421c75e68b0046b252fe5061","after":"8d71e994f11bf82cffd988d3f6294006f91e6941","ref":"refs/heads/main","pushedAt":"2024-09-06T15:21:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Add discord link to website\n\nSummary: doesexactlywhatitsaysonthetin\n\nReviewed By: phlalx\n\nDifferential Revision: D62285788\n\nfbshipit-source-id: af31e7d7f58c512bcf170da5761e5ce320f2e90b","shortMessageHtmlLink":"Add discord link to website"}},{"before":"9d55822592544b51ff7e3d9876e141c79f0d63d2","after":"c0f64b6b3a4258ef421c75e68b0046b252fe5061","ref":"refs/heads/main","pushedAt":"2024-09-05T13:41:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Fix github CI (#470)\n\nSummary: Pull Request resolved: https://github.com/facebookincubator/Glean/pull/470\n\nReviewed By: malanka\n\nDifferential Revision: D62227838\n\nfbshipit-source-id: 01802dd992322466e433a05cbb63c3169a22e014","shortMessageHtmlLink":"Fix github CI (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2507086992\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookincubator/Glean/issues/470\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookincubator/Glean/pull/470/hovercard\" href=\"https://github.com/facebookincubator/Glean/pull/470\">#470</a>)"}},{"before":"56d9feed4831d74963c16ffca3401e812dc715f2","after":"9d55822592544b51ff7e3d9876e141c79f0d63d2","ref":"refs/heads/main","pushedAt":"2024-09-05T09:57:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Don't search for the `extends` relation on functions in Python\n\nSummary:\nThe current implementation of this is a manuall search to great depth and is extremely expensive. from D45096125\nSo much so it breaks CodeHub API Docs and the `describe()` method in glass having O(1) properties for finding parents.\n\nThe extends relation has to be a lookup at depth 1. If it isn't, re-index the content until it is.\n\nRemoving this branch now so that things aren't borked.\n\nNote: I'm not removing the ability to find python overrides in general, just the use of this in the `extends` relation in search related, which specifically expects it to be O(1) at depth =1 (i.e. limit=1 from glass). that's used in Glass::describe() which has to be very cheap.\n\nI suspect this is behind the long lurking comments that Python API pages don't load: the extends relation for both child and parent often run to 15s _per method_\n\nhttps://fburl.com/scuba/glean_server/lc0k4idz\n\nMain issue: 8s to fail to find a method override:\n```\nfbsource.fbcode.python> F = python.FunctionDeclaration { name = \"libfb.py.fb_record.model.Model.is_sharded\" }; python.MethodOverriden { base = F }\n\n0 results, 0 facts, 8423.35ms, 8138216 bytes, 25489 compiled bytes\nFacts searched:\n                    python.NameToSName.4 : 269056\n                          python.SName.4 : 269055\n                       python.Contains.4 : 1993\n             python.BaseClassToDerived.4 : 1630\n            python.FunctionDeclaration.4 : 1\n             python.FunctionDefinition.4 : 1\n                           python.Name.4 : 1\n```\n\nFOR NOW: disable this. Come back with a function -> function lookup table for it.\n\nReviewed By: pepeiborra\n\nDifferential Revision: D62227257\n\nfbshipit-source-id: 46054210dddeba55397dc3933ccfeef184601e7d","shortMessageHtmlLink":"Don't search for the <code>extends</code> relation on functions in Python"}},{"before":"ff0073a8eb8790cf18061487b699acd6f2eafe1e","after":"56d9feed4831d74963c16ffca3401e812dc715f2","ref":"refs/heads/main","pushedAt":"2024-09-05T09:50:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Disable go tests since they're a pain to maintain (#469)\n\nSummary: Pull Request resolved: https://github.com/facebookincubator/Glean/pull/469\n\nReviewed By: pepeiborra\n\nDifferential Revision: D62223837\n\nPulled By: donsbot\n\nfbshipit-source-id: 96c8b20f8288abeb354aef10426a729505ce08f4","shortMessageHtmlLink":"Disable go tests since they're a pain to maintain (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2506633253\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookincubator/Glean/issues/469\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookincubator/Glean/pull/469/hovercard\" href=\"https://github.com/facebookincubator/Glean/pull/469\">#469</a>)"}},{"before":"dbb79921fd543fe0872f8485bcf641e8a544d56a","after":"ff0073a8eb8790cf18061487b699acd6f2eafe1e","ref":"refs/heads/main","pushedAt":"2024-09-04T19:59:24.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"extract thrift parsing logic to dedicated function\n\nSummary: Should be more readable.\n\nReviewed By: malanka\n\nDifferential Revision: D62186125\n\nfbshipit-source-id: 8e5ffd21c3fc037d841f3a52396bf9ed80474262","shortMessageHtmlLink":"extract thrift parsing logic to dedicated function"}},{"before":"16bd686458f4f798cc2eae69a5f50dcda2281bdf","after":"dbb79921fd543fe0872f8485bcf641e8a544d56a","ref":"refs/heads/main","pushedAt":"2024-09-04T14:44:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Use version when parsing and resolving schemas\n\nSummary: If we don't parse with the actual version, we cannot add new langugage constructs properly.\n\nReviewed By: simonmar\n\nDifferential Revision: D62180830\n\nfbshipit-source-id: 75fcab8c8e23e730c41a9d6780251dba8c4ab07c","shortMessageHtmlLink":"Use version when parsing and resolving schemas"}},{"before":"52c2fa4d40f2a32228903f31d60ed5ba3fe1644f","after":"16bd686458f4f798cc2eae69a5f50dcda2281bdf","ref":"refs/heads/main","pushedAt":"2024-09-04T13:50:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Improve error messages for when there's a parse error reading schema from config\n\nSummary: This was useful for me when chasing down a bug. See diff above this one in the stack\n\nReviewed By: malanka\n\nDifferential Revision: D62180831\n\nfbshipit-source-id: 53044eb63e0462d2325be55d8df89685648180cf","shortMessageHtmlLink":"Improve error messages for when there's a parse error reading schema …"}},{"before":"47e8bc3495c620b26728a3617c25255b44fe2aac","after":"52c2fa4d40f2a32228903f31d60ed5ba3fe1644f","ref":"refs/heads/main","pushedAt":"2024-09-04T11:44:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Add -fcoroutines\n\nReviewed By: malanka\n\nDifferential Revision: D62176041\n\nfbshipit-source-id: 771cffbf7b4358c8dd5ee6055199c049b35eca1b","shortMessageHtmlLink":"Add -fcoroutines"}},{"before":"e150bfc87a9b05d69f77c06ca9196b7a78e95dca","after":"47e8bc3495c620b26728a3617c25255b44fe2aac","ref":"refs/heads/main","pushedAt":"2024-09-04T06:24:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Don't gate schema generation on annotation\n\nSummary: Instead of having a separate annotation, fold the gating into the existing gating for schema bundling.\n\nReviewed By: praihan\n\nDifferential Revision: D62147670\n\nfbshipit-source-id: 4f71e375e2f1b228daeb75496aa5fb7ec6399b02","shortMessageHtmlLink":"Don't gate schema generation on annotation"}},{"before":"6061575b8762ce3c8ae62539c233e6b3ef097614","after":"e150bfc87a9b05d69f77c06ca9196b7a78e95dca","ref":"refs/heads/main","pushedAt":"2024-09-03T21:24:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Remove the perf.hack schema.\n\nSummary: We haven't creates these kinds of DBs in quite some time.\n\nReviewed By: phlalx\n\nDifferential Revision: D62125136\n\nfbshipit-source-id: e393d53d105654f56a8924ffdafbc6809125705b","shortMessageHtmlLink":"Remove the perf.hack schema."}},{"before":"14af5dd9e98ee39762728c228e2fefe7a16686d3","after":"6061575b8762ce3c8ae62539c233e6b3ef097614","ref":"refs/heads/main","pushedAt":"2024-09-03T13:27:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"pretty print qualified names\n\nSummary: In thrift facts, the qualified names are of the form \"(file, name)\".  Printing the full file path isn't very pretty. Just the base name + \".\" conforms better to the thrift convention.\n\nReviewed By: donsbot\n\nDifferential Revision: D59376460\n\nfbshipit-source-id: 0676172fa1fc6b8ed026d8915e45b0fbf93fd661","shortMessageHtmlLink":"pretty print qualified names"}},{"before":"9f7527c2d13ec601dbfd7f08257f604554fb13f6","after":"14af5dd9e98ee39762728c228e2fefe7a16686d3","ref":"refs/heads/main","pushedAt":"2024-09-03T10:12:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"add a bit of doc in the tests\n\nSummary: Thrift codemods authors sometimes stumble on these tests and found them confusing. Trying to clarify a bit.\n\nReviewed By: donsbot\n\nDifferential Revision: D62112264\n\nfbshipit-source-id: 37f28b5e03dae6431598e09fd254ebacc57a6417","shortMessageHtmlLink":"add a bit of doc in the tests"}},{"before":"0a48947ac7189e4904672566ee8e2bf71c40a74d","after":"9f7527c2d13ec601dbfd7f08257f604554fb13f6","ref":"refs/heads/main","pushedAt":"2024-09-01T15:11:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Remove extra semi colon from folly/experimental/coro/Merge-inl.h\n\nSummary:\n`-Wextra-semi` or `-Wextra-semi-stmt`\n\nIf the code compiles, this is safe to land.\n\nReviewed By: Orvid\n\nDifferential Revision: D57975880\n\nfbshipit-source-id: 2d60cb964fc917722e735c1afce1412f0f4c4458","shortMessageHtmlLink":"Remove extra semi colon from folly/experimental/coro/Merge-inl.h"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xM1QxOTo0ODo0My4wMDAwMDBazwAAAAS11lQC","startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xM1QxOTo0ODo0My4wMDAwMDBazwAAAAS11lQC","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0wMVQxNToxMTo1NS4wMDAwMDBazwAAAASp4-zS"}},"title":"Activity · facebookincubator/Glean"}