From 59d751d0b3b94564c9049512a5a5a6c509084a4b Mon Sep 17 00:00:00 2001 From: Anushree Subramani Date: Wed, 18 Oct 2017 23:40:24 +0530 Subject: [PATCH] Code review changes made for #11140 --- src/isomorphic/modern/class/ReactNoopUpdateQueue.js | 10 +--------- src/renderers/shared/server/ReactPartialRenderer.js | 10 +--------- 2 files changed, 2 insertions(+), 18 deletions(-) diff --git a/src/isomorphic/modern/class/ReactNoopUpdateQueue.js b/src/isomorphic/modern/class/ReactNoopUpdateQueue.js index 8406b396588fc..6dbee3c143415 100644 --- a/src/isomorphic/modern/class/ReactNoopUpdateQueue.js +++ b/src/isomorphic/modern/class/ReactNoopUpdateQueue.js @@ -20,15 +20,7 @@ function warnNoop(publicInstance, callerName) { const currentComponent = (constructor && (constructor.displayName || constructor.name)) || 'ReactClass'; - const currentComponentError = - callerName + - '(...): Can only update a mounted or mounting component. ' + - 'This usually means you called ' + - callerName + - '() on an unmounted component. ' + - 'This is a no-op.\n\nPlease check the code for the ' + - currentComponent + - ' component.'; + const currentComponentError = `${callerName}_${currentComponent}`; warning( !!errorInfo[currentComponentError], diff --git a/src/renderers/shared/server/ReactPartialRenderer.js b/src/renderers/shared/server/ReactPartialRenderer.js index 35ae900bf02ae..830d8f8c5f352 100644 --- a/src/renderers/shared/server/ReactPartialRenderer.js +++ b/src/renderers/shared/server/ReactPartialRenderer.js @@ -168,15 +168,7 @@ function warnNoop( var constructor = publicInstance.constructor; const currentComponent = (constructor && getComponentName(constructor)) || 'ReactClass'; - const currentComponentError = - callerName + - '(...): Can only update a mounting component. ' + - 'This usually means you called ' + - callerName + - '() outside componentWillMount() on the server. ' + - 'This is a no-op.\n\nPlease check the code for the ' + - currentComponent + - ' component.'; + const currentComponentError = `${callerName}_${currentComponent}`; warning( !!errorInfo[currentComponentError],