From f0770b6b370f483fdd729bdba04069cc783353dc Mon Sep 17 00:00:00 2001 From: Pierre Reimertz Date: Mon, 13 May 2019 07:26:47 -0700 Subject: [PATCH] fixes Xcode path issues containing whitespace when building Release (#24810) Summary: Some users (me included) have projects located in quirky places, resulting whitespaces in the path. An example, , I symlink into my iCloud drive which result in the following path ``` /Users/r/Library/Mobile Documents/com~apple~CloudDocs/_/work/{a_company}/repos.nosync/app ``` This commit quotes the variable to make sure it gets properly passed to the CLI. For reference, similar issue that has been resolved: https://github.com/react-native/react-native/commit/7d4e94edccfc2f642fcbd1d6aa00756f02e3a525 Pull Request resolved: https://github.com/facebook/react-native/pull/24810 Differential Revision: D15316898 Pulled By: cpojer fbshipit-source-id: 4ed2c8391d65d1680e836bfce8c51dfb5763caed --- scripts/react-native-xcode.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/react-native-xcode.sh b/scripts/react-native-xcode.sh index 16c95951309588..34b8d5eed0298e 100755 --- a/scripts/react-native-xcode.sh +++ b/scripts/react-native-xcode.sh @@ -57,7 +57,7 @@ REACT_NATIVE_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)" # in node_modules. PROJECT_ROOT=${PROJECT_ROOT:-"$REACT_NATIVE_DIR/../.."} -cd $PROJECT_ROOT +cd "$PROJECT_ROOT" || exit # Define NVM_DIR and source the nvm.sh setup script [ -z "$NVM_DIR" ] && export NVM_DIR="$HOME/.nvm"