From bbc3657ff4efd0218e02ad9a3c73725a7f8a366c Mon Sep 17 00:00:00 2001
From: David Vacca <dvacca@meta.com>
Date: Wed, 19 Apr 2023 18:44:54 -0700
Subject: [PATCH] Delete unused method exposed in BaseJavaModule (#36907)

Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/36907

Delete unused method exposed in BaseJavaModule

bypass-github-export-checks

Changelog: [Android][Removed] Delete hasConstants() method from BaseJavaModule

Reviewed By: philIip

Differential Revision: D44678688

fbshipit-source-id: 9fd15f2097a6251fd2cf6c81c89370dd18c6bd6c
---
 .../main/java/com/facebook/react/bridge/BaseJavaModule.java  | 5 -----
 .../main/java/com/facebook/react/uimanager/ViewManager.java  | 5 +++--
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/BaseJavaModule.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/BaseJavaModule.java
index 10c60a3e16f908..3b4606afdd9f0f 100644
--- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/BaseJavaModule.java
+++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/BaseJavaModule.java
@@ -56,17 +56,12 @@ public void initialize() {
 
   @Override
   public boolean canOverrideExistingModule() {
-    // TODO(t11394819): Make this final and use annotation
     return false;
   }
 
   @Override
   public void onCatalystInstanceDestroy() {}
 
-  public boolean hasConstants() {
-    return false;
-  }
-
   /**
    * The CatalystInstance is going away with Venice. Therefore, the TurboModule infra introduces the
    * invalidate() method to allow NativeModules to clean up after themselves.
diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManager.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManager.java
index f50610f059dd04..1e16571963be50 100644
--- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManager.java
+++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManager.java
@@ -67,8 +67,9 @@ protected void setupViewRecycling() {
    * For the vast majority of ViewManagers, you will not need to override this. Only override this
    * if you really know what you're doing and have a very unique use-case.
    *
-   * @param viewToUpdate
-   * @param props
+   * @param viewToUpdate {@link T} View instance that will be updated with the props received by
+   *     parameter.
+   * @param props {@link ReactStylesDiffMap} props to update the view with
    */
   public void updateProperties(@NonNull T viewToUpdate, ReactStylesDiffMap props) {
     final ViewManagerDelegate<T> delegate = getDelegate();