From af57ce18d866f15b7a5f11583661f82b81ab3a44 Mon Sep 17 00:00:00 2001 From: Ruslan Shestopalyuk Date: Sat, 17 Jun 2023 06:05:33 -0700 Subject: [PATCH] Hide unnecessarily exposed private methods in GlobalPerformanceLogger (#37947) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/37947 # Changelog: [Internal] - This is a follow-up to an earlier change, that inadvertently added internal methods as public into the GlobalPerformance API. Reviewed By: rubennorte Differential Revision: D46820273 fbshipit-source-id: b960b436e3e5e8f81a76bd3ced7282f76906dfca --- .../Libraries/Utilities/createPerformanceLogger.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/react-native/Libraries/Utilities/createPerformanceLogger.js b/packages/react-native/Libraries/Utilities/createPerformanceLogger.js index 950156c67f81b5..ef701198b8d3d4 100644 --- a/packages/react-native/Libraries/Utilities/createPerformanceLogger.js +++ b/packages/react-native/Libraries/Utilities/createPerformanceLogger.js @@ -48,7 +48,7 @@ class PerformanceLogger implements IPerformanceLogger { // // In most of the other cases this kind of check for `performance` being defined // wouldn't be necessary. - performanceMark(key: string, startTime: number) { + _performanceMark(key: string, startTime: number) { if (this._isLoggingForWebPerformance) { global.performance?.mark?.(key, { startTime, @@ -56,7 +56,7 @@ class PerformanceLogger implements IPerformanceLogger { } } - performanceMeasure( + _performanceMeasure( key: string, start: number | string, end: number | string, @@ -100,7 +100,7 @@ class PerformanceLogger implements IPerformanceLogger { endExtras, }; - this.performanceMeasure( + this._performanceMeasure( `${WEB_PERFORMANCE_PREFIX}_${key}`, startTime, endTime, @@ -220,7 +220,7 @@ class PerformanceLogger implements IPerformanceLogger { this._pointExtras[key] = extras; } - this.performanceMark(`${WEB_PERFORMANCE_PREFIX}_${key}`, timestamp); + this._performanceMark(`${WEB_PERFORMANCE_PREFIX}_${key}`, timestamp); } removeExtra(key: string): ?ExtraValue { @@ -283,7 +283,7 @@ class PerformanceLogger implements IPerformanceLogger { infoLog('PerformanceLogger.js', 'start: ' + key); } - this.performanceMark( + this._performanceMark( `${WEB_PERFORMANCE_PREFIX}_timespan_start_${key}`, timestamp, ); @@ -333,7 +333,7 @@ class PerformanceLogger implements IPerformanceLogger { delete _cookies[key]; } - this.performanceMeasure( + this._performanceMeasure( `${WEB_PERFORMANCE_PREFIX}_${key}`, `${WEB_PERFORMANCE_PREFIX}_timespan_start_${key}`, timestamp,