From 0ae4c47daa6280d2931d8bbf89612b2f1cb106d4 Mon Sep 17 00:00:00 2001 From: Valentin Shergin Date: Tue, 19 Dec 2017 23:34:54 -0800 Subject: [PATCH] `-[UIView _DEBUG_reactShadowView]` was removed Summary: Nobody uses it. If the reference to the bridge is available (which is should be case for testing purposes at least), it is easy to get same information. Reviewed By: mmmulani Differential Revision: D6596376 fbshipit-source-id: 066eeb1e9465b4e0cc9d9b5b6bf41722450870e4 --- React/Modules/RCTUIManager.m | 4 ---- React/Views/UIView+React.h | 10 ---------- React/Views/UIView+React.m | 15 --------------- 3 files changed, 29 deletions(-) diff --git a/React/Modules/RCTUIManager.m b/React/Modules/RCTUIManager.m index a68a0df17c343c..3941c45c84b57c 100644 --- a/React/Modules/RCTUIManager.m +++ b/React/Modules/RCTUIManager.m @@ -976,10 +976,6 @@ - (void)_manageChildren:(NSNumber *)containerTag if (view) { [componentData setProps:props forView:view]; uiManager->_viewRegistry[reactTag] = view; - -#if RCT_DEV - [view _DEBUG_setReactShadowView:shadowView]; -#endif } }); diff --git a/React/Views/UIView+React.h b/React/Views/UIView+React.h index 068f411388efc2..1c90f16dbef806 100644 --- a/React/Views/UIView+React.h +++ b/React/Views/UIView+React.h @@ -109,14 +109,4 @@ */ @property (nonatomic, readonly) UIView *reactAccessibilityElement; -#if RCT_DEV - -/** - Tools for debugging - */ - -@property (nonatomic, strong, setter=_DEBUG_setReactShadowView:) RCTShadowView *_DEBUG_reactShadowView; - -#endif - @end diff --git a/React/Views/UIView+React.m b/React/Views/UIView+React.m index 306af7ba699967..a764eb46a941aa 100644 --- a/React/Views/UIView+React.m +++ b/React/Views/UIView+React.m @@ -37,21 +37,6 @@ - (void)setNativeID:(NSNumber *)nativeID objc_setAssociatedObject(self, @selector(nativeID), nativeID, OBJC_ASSOCIATION_RETAIN_NONATOMIC); } -#if RCT_DEV - -- (RCTShadowView *)_DEBUG_reactShadowView -{ - return objc_getAssociatedObject(self, _cmd); -} - -- (void)_DEBUG_setReactShadowView:(RCTShadowView *)shadowView -{ - // Use assign to avoid keeping the shadowView alive it if no longer exists - objc_setAssociatedObject(self, @selector(_DEBUG_reactShadowView), shadowView, OBJC_ASSOCIATION_ASSIGN); -} - -#endif - - (BOOL)isReactRootView { return RCTIsReactRootView(self.reactTag);