{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":9454675,"defaultBranch":"fb-mysql-8.0.32","name":"mysql-5.6","ownerLogin":"facebook","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2013-04-15T17:54:43.000Z","ownerAvatar":"https://github.com/avatars/u/69631?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1717043595.0","currentOid":""},"activityList":{"items":[{"before":"2dc2bdd4c1b1a63b48ff61610702d0dc3a43dca1","after":"ebcd17e4f5834389ee476496f3190ca58b0fd8c2","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-09-11T06:16:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"MyRocks: allocate WriteBatch objects directly on stack or in containing object (#1490)\n\nSummary:\nThis saves one level of indirection and an extra heap allocation.\n\n- Rdb_writebatch_impl: remove pointer from m_batch field, make is_tx_started\n return true instead of checking the pointer, remove pointer check from\n rollback_stmt, remove new/delete from the constructor and the destructor.\n- Make Rdb_dict_manager::begin return object directly instead of a unique_ptr\n and make this method static.\n- In the affected callstacks, replace WriteBatchBase / WriteBatch pointer\n arguments with reference ones, remove an unused error return from\n Rdb_dict_manager::commit and any \"!= nullptr\" assertions.\n- Rdb_transaction: change get_write_batch return type to WriteBatchBase\n reference instead of a pointer.\n- Add [[nodiscard]] to touched methods, although not universally, as several\n methods have their return values ignored. Remove redundant const from by-value\n parameters.\n\nPull Request resolved: https://github.com/facebook/mysql-5.6/pull/1490\n\nDifferential Revision: D62385501\n\nfbshipit-source-id: 8505ec60e159a137265c8879556a616e52e432e7","shortMessageHtmlLink":"MyRocks: allocate WriteBatch objects directly on stack or in containi…"}},{"before":"5a1ef95d47c07a295f2b6a0caaeb99f777bd3e76","after":"2dc2bdd4c1b1a63b48ff61610702d0dc3a43dca1","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-09-11T05:46:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Do not assume that std::int64_t is identical to long int (#1488)\n\nSummary:\n- printf int64_t values with PRId64\n- Specify std::make_pair template arguments. Alternatively we could introduce a\n constexpr variable for uninitialized opids.\n\nThis fixes new macOS build regressions, only one example per error class:\n\nsql/xa.cc:382:11: error: format specifies type 'long' but the argument has type 'long long' [-Werror,-Wformat]\n info.smallest_lwm_opid.first, info.smallest_lwm_opid.second,\n ^~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\nstorage/innobase/trx/trx0sys.cc:271:16: error: invalid operands to binary expression ('const std::pair' (aka 'const pair') and 'pair::type, typename __unwrap_ref_decay::type>' (aka 'pair'))\n if (lwm_opid != std::make_pair(-1L, -1L)) {\n ~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~\n\nSquash with 5f045b49ed3a2b451773dcebdf7b179fad768045\n\nPull Request resolved: https://github.com/facebook/mysql-5.6/pull/1488\n\nDifferential Revision: D62188672\n\nfbshipit-source-id: ea017e5bef7f4774d377bee7fc5da87e19cc2b40","shortMessageHtmlLink":"Do not assume that std::int64_t is identical to long int (#1488)"}},{"before":"e1bd16415ff21b95a14d3b7ed56f7d083a652c11","after":"5a1ef95d47c07a295f2b6a0caaeb99f777bd3e76","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-09-10T16:37:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"record results for thread_pool.nesting and thread_pool.idx_threads\n\nSummary: It looks like that the two tests are failing because of result content mismatch, so I just recorded the results to fix the test failures.\n\nDifferential Revision: D62395669\n\nfbshipit-source-id: 4080123f5c229322127b8f2819a686998047b789","shortMessageHtmlLink":"record results for thread_pool.nesting and thread_pool.idx_threads"}},{"before":"620fb02315fdcdd085fb538bf99756918dc43f19","after":"e1bd16415ff21b95a14d3b7ed56f7d083a652c11","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-09-10T16:26:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Update RocksDB submodule to fb.9.6\n\nSummary: update-submodule: rocksdb\n\nDifferential Revision: D62401714\n\nfbshipit-source-id: 2c403803dc3bc2b55d578a35d1ebd72a6206da10","shortMessageHtmlLink":"Update RocksDB submodule to fb.9.6"}},{"before":"8a40c1181152dc4a2263b0b90596fa770bb7d3d2","after":"620fb02315fdcdd085fb538bf99756918dc43f19","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-09-10T05:29:14.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Add yields during index analysis on range queries\n\nSummary:\nWe see stalls like:\n\n```\n\n[\"00000000000c9e4b __strstr_sse2_unaligned\n\",\"00000000064a729c ha_innobase::index_flags(unsigned int, unsigned int, bool) const\n /data/sandcastle/boxes/trunk-git-mysql80-int/_build-8.0-rpm/BUILD/fb-mysql-8.0.32/storage/innobase/handler/ha_innodb.cc:6499\n\",\"0000000003862849 Field::optimize_range(unsigned int, unsigned int) const\n /data/sandcastle/boxes/trunk-git-mysql80-int/_build-8.0-rpm/BUILD/fb-mysql-8.0.32/sql/field.cc:2136\n\",\"0000000003ac6df2 get_mm_leaf(THD*, RANGE_OPT_PARAM*, Item*, Field*, KEY_PART*, Item_func::Functype, Item*, bool*) [clone .__uniq.293250380616179225018608113956866640134]\n /data/sandcastle/boxes/trunk-git-mysql80-int/_build-8.0-rpm/BUILD/fb-mysql-8.0.32/sql/range_optimizer/range_analysis.cc:1450\n\",\"00000000064b6e39 get_mm_parts(THD*, RANGE_OPT_PARAM*, unsigned long, unsigned long, Item_func*, Field*, Item_func::Functype, Item*) [clone .__uniq.293250380616179225018608113956866640134]\n /data/sandcastle/boxes/trunk-git-mysql80-int/_build-8.0-rpm/BUILD/fb-mysql-8.0.32/sql/range_optimizer/range_analysis.cc:1103\n\",\"00000000064b811b get_func_mm_tree(THD*, RANGE_OPT_PARAM*, unsigned long, unsigned long, bool, Item*, Item_func*, Item*, bool) [clone .__uniq.293250380616179225018608113956866640134]\n /data/sandcastle/boxes/trunk-git-mysql80-int/_build-8.0-rpm/BUILD/fb-mysql-8.0.32/sql/range_optimizer/range_analysis.cc:375\n\",\"00000000064b3ff9 get_full_func_mm_tree(THD*, RANGE_OPT_PARAM*, unsigned long, unsigned long, unsigned long, bool, Item*, Item_func*, Item*, bool) [clone .__uniq.293250380616179225018608113956866640134]\n /data/sandcastle/boxes/trunk-git-mysql80-int/_build-8.0-rpm/BUILD/fb-mysql-8.0.32/sql/range_optimizer/range_analysis.cc:775\n\",\"00000000064b3d96 get_mm_tree(THD*, RANGE_OPT_PARAM*, unsigned long, unsigned long, unsigned long, bool, Item*)\n /data/sandcastle/boxes/trunk-git-mysql80-int/_build-8.0-rpm/BUILD/fb-mysql-8.0.32/sql/range_optimizer/range_analysis.cc:0\n\",\"00000000064a9f47 test_quick_select(THD*, MEM_ROOT*, MEM_ROOT*, Bitmap<64u>, unsigned long, unsigned long, unsigned long long, bool, enum_order, TABLE*, bool, Item*, Bitmap<64u>*, bool, bool, Query_block*, AccessPath**)\n /data/sandcastle/boxes/trunk-git-mysql80-int/_build-8.0-rpm/BUILD/fb-mysql-8.0.32/sql/range_optimizer/range_optimizer.cc:658\n\",\"00000000064aee29 JOIN::estimate_rowcount()\n /data/sandcastle/boxes/trunk-git-mysql80-int/_build-8.0-rpm/BUILD/fb-mysql-8.0.32/sql/sql_optimizer.cc:6326\n\",\"00000000064afe9a JOIN::make_join_plan()\n /data/sandcastle/boxes/trunk-git-mysql80-int/_build-8.0-rpm/BUILD/fb-mysql-8.0.32/sql/sql_optimizer.cc:5439\n\",\"0000000006380822 JOIN::optimize(bool)\n /data/sandcastle/boxes/trunk-git-mysql80-int/_build-8.0-rpm/BUILD/fb-mysql-8.0.32/sql/sql_optimizer.cc:728\n\",\"000000000642e3ba Query_expression::optimize(THD*, TABLE*, bool, bool)\n /data/sandcastle/boxes/trunk-git-mysql80-int/_build-8.0-rpm/BUILD/fb-mysql-8.0.32/sql/sql_select.cc:1902\n -> /data/sandcastle/boxes/trunk-git-mysql80-int/_build-8.0-rpm/BUILD/fb-mysql-8.0.32/sql/sql_union.cc\n\",\"000000000643644d Sql_cmd_dml::execute(THD*)\n /data/sandcastle/boxes/trunk-git-mysql80-int/_build-8.0-rpm/BUILD/fb-mysql-8.0.32/sql/sql_select.cc:852\n\",\"00000000063fcb94 mysql_execute_command(THD*, bool, unsigned long long*)\n /data/sandcastle/boxes/trunk-git-mysql80-int/_build-8.0-rpm/BUILD/fb-mysql-8.0.32/sql/sql_parse.cc:5497\n\",\"000000000640edc6 dispatch_sql_command(THD*, Parser_state*, unsigned long long*)\n /data/sandcastle/boxes/trunk-git-mysql80-int/_build-8.0-rpm/BUILD/fb-mysql-8.0.32/sql/sql_parse.cc:6284\n\",\"000000000641c53e dispatch_command(THD*, COM_DATA const*, enum_server_command)\n /data/sandcastle/boxes/trunk-git-mysql80-int/_build-8.0-rpm/BUILD/fb-mysql-8.0.32/sql/sql_parse.cc:2565\n\",\"000000000642871a do_command(THD*)\n /data/sandcastle/boxes/trunk-git-mysql80-int/_build-8.0-rpm/BUILD/fb-mysql-8.0.32/sql/sql_parse.cc:1745\n\",\"0000000006ed3ba7 mysql::thread_pool::TpConnHandler::processEvent(void*)\n\",\"0000000006ef5726 mysql::thread_pool::TpWorkerPool::processWorker(void*)\n\",\"0000000004ce7dea pfs_spawn_thread(void*) [clone .__uniq.122401345426557941287095112464970817435] [clone .llvm.6000662921547167929]\n /data/sandcastle/boxes/trunk-git-mysql80-int/_build-8.0-rpm/BUILD/fb-mysql-8.0.32/storage/perfschema/pfs.cc:3022\n\",\"000000000009abc8 start_thread\n\",\"000000000012cf5b __clone3\n\n```\n\nConsidering that we evaluate multiple indexes in this stack, adding yields.\n\nDifferential Revision: D61760605\n\nfbshipit-source-id: 16df60f5084a62f853b149d665da7bf5d500a58d","shortMessageHtmlLink":"Add yields during index analysis on range queries"}},{"before":"d89f0a176b9bfe304cb815d0efe4153962c0f6dd","after":"8a40c1181152dc4a2263b0b90596fa770bb7d3d2","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-09-10T05:22:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Control how we yield while scanning many rows\n\nSummary:\nToday, while scanning rows, we check for yield with every row. Depending on the yield condition and the number of rows to scan, this can be very expensive and make queries go slower as well as increase the CPU utilization.\n\nAdding a knob here to tune the yield check frequency. Note, this is different from the actual yielding.\n\nWith examined_rows = 100,\nBefore:\nhttps://fburl.com/strobelight/5aepse73\n\nAfter:\nhttps://fburl.com/strobelight/ds28d3oo\n\ncheck_yield no longer appears in the CPU profiler in index_next stack.\n\n======\n\nclock_gettime however is one of the next things to look at. It has a strong presence in the profiler.\n\nDifferential Revision: D62069634\n\nfbshipit-source-id: c6cff5f8c8e3b341146d1069008c4b4b8c725ca7","shortMessageHtmlLink":"Control how we yield while scanning many rows"}},{"before":"6389d8d6bf3264233b16a684c94cec5e2421cea4","after":"d89f0a176b9bfe304cb815d0efe4153962c0f6dd","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-09-09T16:44:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"add CODE_OF_CONDUCT and CONTRIBUTING\n\nSummary: add CODE_OF_CONDUCT and CONTRIBUTING per Open Source Team requirement\n\nDifferential Revision: D62311572\n\nfbshipit-source-id: 82ad88d7118e676405eac859638576dcf68d5e98","shortMessageHtmlLink":"add CODE_OF_CONDUCT and CONTRIBUTING"}},{"before":"04220ff47dfbe03859820ca03527484f1ba49064","after":"6389d8d6bf3264233b16a684c94cec5e2421cea4","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-09-06T21:58:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Enable file checksum for clone startup (#1489)\n\nSummary:\nThis change is to enable file checksum check only for recipients of clone. For regular startup, we don't do the sst file checksum check.\n\nPull Request resolved: https://github.com/facebook/mysql-5.6/pull/1489\n\nDifferential Revision: D62208092\n\nfbshipit-source-id: 7afa5a4fa3957ec3761c37ed4cf6a888d774d10c","shortMessageHtmlLink":"Enable file checksum for clone startup (#1489)"}},{"before":"6a81e09558e56bc9595cc443a3c0a7e8711c0496","after":"04220ff47dfbe03859820ca03527484f1ba49064","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-09-06T21:36:49.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Fix -DWITHOUT_SERVER=ON build, part 2 (#1478)\n\nSummary:\nMark inline_mysql_thread_get_held_locks arguments as maybe_unused to fix\ncompilation error when HAVE_PSI_THREAD_INTERFACE is not declared.\n\nThis partially fixes https://github.com/facebook/mysql-5.6/issues/1476 together\nwith other PRs\n\nSquash with d69bb8a2ab39b2bf207a527300eb77ebf0a2e20d\n\nPull Request resolved: https://github.com/facebook/mysql-5.6/pull/1478\n\nDifferential Revision: D62188726\n\nfbshipit-source-id: 12a8b710f1edae6623e8ab05eeccf469ed01fb60","shortMessageHtmlLink":"Fix -DWITHOUT_SERVER=ON build, part 2 (#1478)"}},{"before":"00c726c515a6ae9cb3d98ef4361afb54212b41d4","after":"6a81e09558e56bc9595cc443a3c0a7e8711c0496","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-09-06T21:29:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Partially fix -DWITHOUT_SERVER=ON build (#1477)\n\nSummary:\nDo not declare inline_mysql_get_statement_cpu_time if\nHAVE_PSI_STATEMENT_INTERFACE is not defined.\n\nWill fix https://github.com/facebook/mysql-5.6/issues/1476 together with other\nPRs that squash to different commits.\n\nSquash with f6743061c2a1bcf7e10d103409d192e6b1df7d5a\n\nPull Request resolved: https://github.com/facebook/mysql-5.6/pull/1477\n\nDifferential Revision: D62188754\n\nfbshipit-source-id: 030309e3d07ea619a9874bf4c35dc3d2a57b6e89","shortMessageHtmlLink":"Partially fix -DWITHOUT_SERVER=ON build (#1477)"}},{"before":"68a387e1a3fdd27b0a4d803ba1492ec94994623a","after":"62403402bd867663be98b67238a7cd48bf77e82e","ref":"refs/heads/gh-pages","pushedAt":"2024-09-06T18:25:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bladepan","name":"Pan","path":"/bladepan","primaryAvatarUrl":"https://github.com/avatars/u/977284?s=80&v=4"},"commit":{"message":"add Terms Of Use, Privacy Policy, and Copyright Statement to page footer","shortMessageHtmlLink":"add Terms Of Use, Privacy Policy, and Copyright Statement to page footer"}},{"before":"adcb0233b3949c3ff6d7fa492cb83823eb9bb7f2","after":"00c726c515a6ae9cb3d98ef4361afb54212b41d4","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-09-06T16:40:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Implement LAST_INSERT_IDS function (#1469)\n\nSummary:\nThis is a multiple-value counterpart of the existing LAST_INSERT_ID function.\nIts results are returned as a table.\n\n- Hardcode the function name LAST_INSERT_IDS into the lexer and the parser due\n to how MySQL supports table-returning functions, patch the parser for the\n function.\n- To keep the autoincrement value set efficiently, implement a data structure\n that 1) uses delta encoding for consecutive values; 2) special-cases encoding\n of consecutive delta equal to one values into a single number.\n- Maintain the last_insert_ids set in THD for the previous and the current\n statement, similar to existing first_successful_insert_id_in_prev_stmt and\n first_successful_insert_id_in_cur_stmt fields.\n- Add a main.last_insert_ids test.\n- Since MyISAM is an engine that supports composite primary keys with\n autoincrement suffixes, this scenario is supported as well by allowing the\n values to be actually non-monotonic by delta encoding writing large deltas\n that make the value wrap around. For this case add a\n main.last_insert_ids_myisam test.\n\nPull Request resolved: https://github.com/facebook/mysql-5.6/pull/1469\n\nDifferential Revision: D60675155\n\nfbshipit-source-id: c702048a14763db37140407c40f0d7ca648d5901","shortMessageHtmlLink":"Implement LAST_INSERT_IDS function (#1469)"}},{"before":"7c087d2f5bc615a0fd217fce14958cd0c9f498a7","after":"adcb0233b3949c3ff6d7fa492cb83823eb9bb7f2","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-09-05T17:40:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Add yields to myrocks clone\n\nSummary: After adding yields for chunks in the main loop, this is the only yield stack remaining on the clone path: https://fburl.com/scuba/mysql_thread_pool_stalls/jibfj8qd. To address them this change adds yields to the loops found in `donor::copy()`.\n\nDifferential Revision: D62220291\n\nfbshipit-source-id: 63132134baf1749bb44df56b07e51390ac152143","shortMessageHtmlLink":"Add yields to myrocks clone"}},{"before":"82f97d7c7b5405be6e852dedb1f7cec5d9fd84ef","after":"7c087d2f5bc615a0fd217fce14958cd0c9f498a7","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-09-04T21:48:09.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"hermanlee","name":"Herman Lee","path":"/hermanlee","primaryAvatarUrl":"https://github.com/avatars/u/6656176?s=80&v=4"},"commit":{"message":"fix mysql fbcode test failures(mtr_parallel_main_4 and mtr_parallel_main_8)\n\nSummary:\nsome mysql test set(mtr_parallel_main_4 and mtr_parallel_main_8) are\nfailing. They are only failing under stress run. The test was\nfailing because of a small difference in the query plan cost values:\nP1541496988. For rocksdb, it could be possible as the index stats might\nchange.\n\nTo fix the test failures in fbcode, we use regex expression to strip out the cost value for the query plan\n\nDifferential Revision: D62089594\n\nfbshipit-source-id: a2f0f9315ebd931c7ec543deefc28a5e391d123c","shortMessageHtmlLink":"fix mysql fbcode test failures(mtr_parallel_main_4 and mtr_parallel_m…"}},{"before":"8bf72fabd3b385ffe3f64dce1ba07b612559b1c5","after":"82f97d7c7b5405be6e852dedb1f7cec5d9fd84ef","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-09-04T19:32:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"fix mysql fbcode test failures(mtr_parallel_main_4 and mtr_parallel_main_8)\n\nSummary:\nsome mysql test set(mtr_parallel_main_4 and mtr_parallel_main_8) are failing in fbcode. They are only failing under stress run: https://www.internalfb.com/phabricator/paste/view/P1541496988. The test was failing because of a small difference in the query plan cost values: P1541496988. For rocksdb, it could be possible as the index stats might change.\n\nTo fix the test failures in fbcode, we use regex expression to strip out the cost value for the query plan\n\nDifferential Revision: D62089594\n\nfbshipit-source-id: a2f0f9315ebd931c7ec543deefc28a5e391d123c","shortMessageHtmlLink":"fix mysql fbcode test failures(mtr_parallel_main_4 and mtr_parallel_m…"}},{"before":"4c4c05a8eb59c1c66780556cb2a8baee5ddd3a7e","after":"8bf72fabd3b385ffe3f64dce1ba07b612559b1c5","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-09-04T17:29:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Make MyRocks transactions never expire additional rows with TTL while running (#1458)\n\nSummary:\nThe TTL row filtering is governed by Rdb_transaction::m_snapshot_timestamp\nfield. This field sometimes get reset to zero when a snapshot is released,\nindicating that it should be reinitialized at the next snapshot, or to the\ncurrent timestamp (when a single statement in a multi-statement transaction gets\nrolled back). The timestamp going forward means that additional rows may be\nhidden in the same transaction if they happened to expire between the two\nsnapshots. Change it so that additional rows are never expired:\n\n- Only initialize the field once per transaction, when the first snapshot is\n created.\n- Do not touch it for single-statement rollbacks in multi-statement\n transactions.\n- Rename the field to m_earliest_snapshot_ts to better reflect what it does.\n- Change the global transaction list to be sorted by the oldest snapshot\n timestamp, so that the oldest global one can be found by reading the\n transaction at the list head. The transactions without snapshot are inserted\n to the its tail, and reinserted as needed upon acquiring the first snapshot.\n To make reinsertions fast, a third list pointer is maintained that points to\n the newest transaction with a snapshot.\n- Extend the SHOW ENGINE ROCKSDB TRANSACTION STATUS output with transactions\n that currently do not have a snapshot, for both cases of having a snapshot\n before and never having had one.\n- Add a test to rocksdb.ttl_primary_read_filtering for the behavior\n difference introduced by this commit.\n\nAt the same time:\n- Initialize m_earliest_snapshot_ts from the binlog HLC instead of the current\n system time.\n\nPull Request resolved: https://github.com/facebook/mysql-5.6/pull/1458\n\nDifferential Revision: D58089107\n\nfbshipit-source-id: de9224afb014799652aedb67cea9459764fee1c1","shortMessageHtmlLink":"Make MyRocks transactions never expire additional rows with TTL while…"}},{"before":"9fc35fa64fb68b443d632e831db50ab02ac9bfce","after":"4c4c05a8eb59c1c66780556cb2a8baee5ddd3a7e","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-09-04T04:41:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Handle server disconnections in nonblocking mysql_change_user callpath\n\nSummary:\nFix the error handling on the change user callpath for async client.\nIn many places code was incorrectly relying on just status or return param value to check errors. Fixing those in the authorization call stack and making sure there are right validations\n\nDifferential Revision: D60982780\n\nfbshipit-source-id: 78366b9cfa632dc31ca543318d707476a197319f","shortMessageHtmlLink":"Handle server disconnections in nonblocking mysql_change_user callpath"}},{"before":"9888c38fd7995d032712bc10916e3d08e80e8658","after":"9fc35fa64fb68b443d632e831db50ab02ac9bfce","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-09-04T02:20:05.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Adding status var counter to tell if recovery opids match computed opids\n\nSummary:\nWe'll compare the opids from the engine to the computed opid\nusing executed gtids and bump a counter if there is a mismatch. This is\nfor validation of engine opids in prod.\n\nDifferential Revision: D62076572\n\nfbshipit-source-id: 0133fdd33c66ccbd74f2dd9521f7983d8b6e83dd","shortMessageHtmlLink":"Adding status var counter to tell if recovery opids match computed opids"}},{"before":"6b86f372e10ad413bcb4224590210005b9295f2e","after":"9888c38fd7995d032712bc10916e3d08e80e8658","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-09-03T23:39:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Fix flaky rpl_raft_show_raft_logs_with_opid MTR tests\n\nSummary: Add \tinclude/sync_slave_sql_with_master.inc after writes and rotate. Make sure replica receives the writes to avoid flaky tests.\n\nDifferential Revision: D62156728\n\nfbshipit-source-id: 6981f2c43c92849c942b1dde6a93315ded18e38a","shortMessageHtmlLink":"Fix flaky rpl_raft_show_raft_logs_with_opid MTR tests"}},{"before":"13c6e33e59e62f8f46fdeedb916f77ee2d05525f","after":"6b86f372e10ad413bcb4224590210005b9295f2e","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-09-03T17:00:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Remove redundant include (#1479)\n\nSummary:\nTogether with the other PRs, this fixes\nhttps://github.com/facebook/mysql-5.6/issues/1476\n\nSquash with 515634e4a14b47a8f55f0db0720b3685b2d343ed\n\nPull Request resolved: https://github.com/facebook/mysql-5.6/pull/1479\n\nDifferential Revision: D61977201\n\nfbshipit-source-id: e5501f977d798e657e39eb18f88e83d27922a84b","shortMessageHtmlLink":"Remove redundant include (#1479)"}},{"before":"179643f9f9b48f28736e5d8cf43f50827b999320","after":"13c6e33e59e62f8f46fdeedb916f77ee2d05525f","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-09-03T16:39:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Utilize table category to determine if it's a system table\n\nSummary:\nWhile profiling queries which scan the entire MyRocks table, we see a significant time spent verifying if the table is a system table. Such calls always provide the same answer but yet, we perform a lot of string manipulation to get that answer.\n\nHere's before: https://fburl.com/strobelight/tbjifp2h\n\nhere's after: https://fburl.com/strobelight/8zogxqmf\n\nWe see 10% reduction in contribution of check_yield.\n\nDifferential Revision: D61989310\n\nfbshipit-source-id: 8aefdf8253affe896f5196f773cf5f3b28250661","shortMessageHtmlLink":"Utilize table category to determine if it's a system table"}},{"before":"d05bcb4ad692d2f86e199fe76cd871714f43b047","after":"179643f9f9b48f28736e5d8cf43f50827b999320","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-08-30T22:31:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Adding support for database rewrite using session variable\n\nSummary:\nTo support rollback on resharding, we need to apply binlogs from one database to another. After this diff, we can just run the following code at the start of the binlog application:\n```\nSET SESSION binlog_db_rewrite_map = 'old_db : new_db';\n```\nThis rename only needs to be handled in 2 places:\n1. Table Map Log Event\n2. Query Log Event\n\nNOTE: If the customer is using `database_name.table_name` in their raw DDL query, the `database_name` in the query won't be updated. This shouldn't matter for us as we block x-database operations. To make sure this is working as expected, we will add a test to ensure that such a query fails after rewriting.\n\nDifferential Revision: D59792716\n\nfbshipit-source-id: 721c200d77c1b0a92a5cc20065435894479e6640","shortMessageHtmlLink":"Adding support for database rewrite using session variable"}},{"before":"6637b51c7df3fb8e2c4994dd0358acb92f7ba017","after":"d05bcb4ad692d2f86e199fe76cd871714f43b047","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-08-30T18:45:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"fix innodb virtual index rollback crash when index id exceeds uint32\n\nSummary:\nwhen rollback a virtual index record and the index_id is greater or equal to `1ull << 32`, the server could not read correct index_id back from undo log using mach_read_next_compressed. This caused the virtual index record not rolled back correctly, and causing crash later on.\n\n- use mach_u64_write_much_compressed instead of mach_write_compressed when writing virtual index id to undo log. when id is less than 2^32, mach_u64_write_much_compressed calls mach_write_compressed, otherwise, it writes 0xFF as first bytes, mach_write_compressed never use 0xFF as first byte. So this change is safe.\n- use mach_read_next_much_compressed insteand of mach_read_next_compressed when reading virtual index id from undo log\n\nDifferential Revision: D61918836\n\nfbshipit-source-id: 618a4981a51046e89c6a7ec91fcc48c2ed9a438e","shortMessageHtmlLink":"fix innodb virtual index rollback crash when index id exceeds uint32"}},{"before":"b0564d438b78082047b99a3f17a77e2754edc304","after":"6637b51c7df3fb8e2c4994dd0358acb92f7ba017","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-08-30T18:23:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Fix tsan reported error accessing CHARSET_INFO state\n\nSummary:\nThe CHARSET_INFO's state variable is accessed outside the lock to check\nfor readiness, but this triggers tsan issues. Change the variable to an\natomic and update the gunittest to explicitly copy/load the members\nof the class.\n\nDifferential Revision: D62032128\n\nfbshipit-source-id: 5533da4921d3e535d419669b5a32182bdee37418","shortMessageHtmlLink":"Fix tsan reported error accessing CHARSET_INFO state"}},{"before":"c038404a215741a3489400debde271d58fe3cd7f","after":"b0564d438b78082047b99a3f17a77e2754edc304","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-08-29T20:23:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"use string append instead of for loop when reading vector index value\n\nSummary: as title\n\nDifferential Revision: D61947339\n\nfbshipit-source-id: a9e900bcba0ae2fced2d12d91b8904335064cf62","shortMessageHtmlLink":"use string append instead of for loop when reading vector index value"}},{"before":"00dde86c2543ce65524c0ff5f8b635779493f812","after":"c038404a215741a3489400debde271d58fe3cd7f","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-08-29T19:04:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Fix rpl_raft_opid_recovery\n\nSummary: Need to add have_debug to skip release runs\n\nDifferential Revision: D61984759\n\nfbshipit-source-id: 4c66940513b91273b04bd8f4c61f441f1158b243","shortMessageHtmlLink":"Fix rpl_raft_opid_recovery"}},{"before":"ffa07392b132a5ac9dedba5fae6de9cb6d10695a","after":"00dde86c2543ce65524c0ff5f8b635779493f812","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-08-29T18:28:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Fix assertion in PARSE_FLAG macro\n\nSummary:\nRELAXED_UNIQUE_CHECKS_F was not accounted for in ALL_FLAGS\ncausing assertion (in debug mode) and UNKNOWN_FLAG warning in\nmysqlbinlog output (in release mode) when unique checks are disabled by\nclients.\n\nDifferential Revision: D61935531\n\nfbshipit-source-id: 6d8f01a59a5909cdf7d2f8ece2db6b4847135938","shortMessageHtmlLink":"Fix assertion in PARSE_FLAG macro"}},{"before":"482874b88c2d41d4104b659fd400db86b09e3e7f","after":"ffa07392b132a5ac9dedba5fae6de9cb6d10695a","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-08-26T21:48:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Support evermeta in mysqldump --dump-fbobj-assoc-stats\n\nSummary: As a part of the execution for re-attributing everstore cost on UDB to its own platform for MCP we want to start collecting the usage of evermeta similar to how other UDB data demand is collected. All existing UDB table demanded is collected through daily logical backup run which under the hood use mysqldump --dump-fbobj-assoc-stats command. This change is including `evermeta` table as a new field type (without further breakdown of IDs) in the output for this command.\n\nDifferential Revision: D59171858\n\nfbshipit-source-id: c3b0f79ed439a003f26c510f931a6eace115b29a","shortMessageHtmlLink":"Support evermeta in mysqldump --dump-fbobj-assoc-stats"}},{"before":"f04874415c47b8eaed3a83d75a4df13a80bedc51","after":"482874b88c2d41d4104b659fd400db86b09e3e7f","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-08-26T16:59:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"update sql_wsenv MTR\n\nSummary:\nTrivial changes:\n1. use parallel in xargs\n2. add one or error code for select_into_outfile_error_wsenv.result\n\nDifferential Revision: D61736825\n\nfbshipit-source-id: 12d6f4a5d360f33c77877835bd88015a758ee8ba","shortMessageHtmlLink":"update sql_wsenv MTR"}},{"before":"93093d3a44dfa19c7eb7b1d633e32ec356c81908","after":"f04874415c47b8eaed3a83d75a4df13a80bedc51","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-08-24T00:05:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://github.com/avatars/u/6422482?s=80&v=4"},"commit":{"message":"Disable running main.upgrade as root\n\nSummary: as titled\n\nDifferential Revision: D61747443\n\nfbshipit-source-id: 41e521f6019a3b2a359c5c71e509df62141a76d1","shortMessageHtmlLink":"Disable running main.upgrade as root"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEstIe4wA","startCursor":null,"endCursor":null}},"title":"Activity · facebook/mysql-5.6"}