From 855796816a941ca14e025df3f5a80fcd63bfbc21 Mon Sep 17 00:00:00 2001 From: Rob Hogan Date: Sun, 24 Sep 2023 07:16:28 -0700 Subject: [PATCH] Remove `react-refesh` re-export from `metro-runtime`, reduce it to a dev dependency Summary: This removes the unused module `fast-refresh` from `metro-runtime`, removing our dependency on `react-refresh`. `fast-refresh` is unused anywhere as far as I can tell, but as other modules in `metro-runtime/src/module` are designed to be imported by consumers using subpaths, I'd regard this as a breaking change. (In general, only exports from module entry points, or explicit `package.json#exports` are considered part of Metro's public API) ``` * **[Breaking]:** Remove `metro-runtime/src/modules/fast-refresh` and `react-refresh` dependency - now owned by RN's Babel preset. ``` Reviewed By: huntie Differential Revision: D49500556 fbshipit-source-id: 842bd84cfde44b2d27e58e6e7d568248cf38eb34 --- packages/metro-runtime/package.json | 4 ++-- packages/metro-runtime/src/modules/fast-refresh.js | 11 ----------- 2 files changed, 2 insertions(+), 13 deletions(-) delete mode 100644 packages/metro-runtime/src/modules/fast-refresh.js diff --git a/packages/metro-runtime/package.json b/packages/metro-runtime/package.json index 74e7e8d378..c5f96d5fe4 100644 --- a/packages/metro-runtime/package.json +++ b/packages/metro-runtime/package.json @@ -13,12 +13,12 @@ }, "license": "MIT", "dependencies": { - "@babel/runtime": "^7.0.0", - "react-refresh": "^0.14.0" + "@babel/runtime": "^7.0.0" }, "devDependencies": { "@babel/core": "^7.20.0", "react": "^18.2.0", + "react-refresh": "^0.14.0", "react-test-renderer": "^18.2.0" }, "engines": { diff --git a/packages/metro-runtime/src/modules/fast-refresh.js b/packages/metro-runtime/src/modules/fast-refresh.js deleted file mode 100644 index 457064ad4d..0000000000 --- a/packages/metro-runtime/src/modules/fast-refresh.js +++ /dev/null @@ -1,11 +0,0 @@ -/** - * Copyright (c) Meta Platforms, Inc. and affiliates. - * - * This source code is licensed under the MIT license found in the - * LICENSE file in the root directory of this source tree. - * - * @format - * @flow - */ - -module.exports = require('react-refresh/runtime');