From c5aaae1b00cd036697e96c5f9178de0908ba8b1a Mon Sep 17 00:00:00 2001 From: Sam Daulton Date: Mon, 4 Mar 2024 16:46:16 -0800 Subject: [PATCH] improve flakey test reliability Summary: set seeds to reduce flakiness Reviewed By: bernardbeckerman Differential Revision: D54508799 --- ax/core/tests/test_experiment.py | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/ax/core/tests/test_experiment.py b/ax/core/tests/test_experiment.py index af41dae2fa7..b85643b9d73 100644 --- a/ax/core/tests/test_experiment.py +++ b/ax/core/tests/test_experiment.py @@ -10,7 +10,10 @@ from typing import Dict, List, Type from unittest.mock import MagicMock, patch +import numpy as np + import pandas as pd +import torch from ax.core import BatchTrial, Trial from ax.core.arm import Arm from ax.core.base_trial import TrialStatus @@ -1388,10 +1391,15 @@ def test_WarmStartMapData(self) -> None: @fast_botorch_optimize def test_batch_with_multiple_generator_runs(self) -> None: exp = get_branin_experiment() - sobol = Models.SOBOL(experiment=exp, search_space=exp.search_space) + # set seed to avoid transient errors caused by duplicate arms, + # which leads to fewer arms in the trial than expected. + seed = 0 + sobol = Models.SOBOL(experiment=exp, search_space=exp.search_space, seed=seed) exp.new_batch_trial(generator_runs=[sobol.gen(n=7)]).run().complete() data = exp.fetch_data() + torch.manual_seed(seed) + np.random.seed(seed) gp = Models.BOTORCH_MODULAR( experiment=exp, search_space=exp.search_space, data=data )