Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fiedsets as tabs CSS issue #317

Closed
bloodwithmilk25 opened this issue Sep 6, 2023 · 6 comments
Closed

Fiedsets as tabs CSS issue #317

bloodwithmilk25 opened this issue Sep 6, 2023 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@bloodwithmilk25
Copy link

bloodwithmilk25 commented Sep 6, 2023

Python
3.11
Django
4.2.2
django-admin-interface
0.26.0

When the "Fieldsets as tabs" feature is enabled, the help text CSS does not look right.
Should it look like this or is it a bug? We don't have any custom CSS.
It looks like it's related to the Django version we are using. On my other project, I have Django 4.1.9 and CSS is fine. When I updated Django on that other project, the issue appeared there too.

Screenshot 2023-09-06 at 18 57 04 Screenshot 2023-09-06 at 18 53 48

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@bloodwithmilk25 bloodwithmilk25 added the bug Something isn't working label Sep 6, 2023
@fabiocaccamo
Copy link
Owner

fabiocaccamo commented Sep 6, 2023

@bloodwithmilk25 thank you for reporting this.

Should it look like this or is it a bug?

It's a CSS bug.

If you disable fieldsets as tabs option, does the problem persist?

@bloodwithmilk25
Copy link
Author

@fabiocaccamo No, it looks just fine without this option

@fabiocaccamo
Copy link
Owner

fabiocaccamo commented Sep 18, 2023

@bloodwithmilk25 I checked the cause of this problem and:

  • the good news is that it seems that finally the help_text is left-aligned with the inputs independently by the left margin.

  • the bad news is that fixing this issue now, would result in breaking the layout for all users that are not using the latest django version.

Patching the CSS only for the latest version would work, but it would also implies some additional maintenance work in the future and I would prefer to avoid it.

So in the end I would opt for having the best compatibility with the latest/coming django versions, users can avoid to upgrade this library to avoid unexpected misalignments.

What do you think?

@bloodwithmilk25
Copy link
Author

bloodwithmilk25 commented Sep 19, 2023

@fabiocaccamo I think you are right. It's not a big deal since it's only happening on django 4.2 and with a "Fieldsets as tabs" enabled, so I don't think many users are affected. We can return to it later when more users use Django >=4.2.

Would you mind posting a patched section of the CSS? I'll patch it just in my project.
Thank you!

fabiocaccamo added a commit that referenced this issue Jan 8, 2024
@fabiocaccamo
Copy link
Owner

@bloodwithmilk25 this has been fixed in 0.28.3 version, please let me know if you notice any other problem.

@bloodwithmilk25
Copy link
Author

@fabiocaccamo Thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants