Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing a note on key lane during keysound playback causes a crash. #9

Closed
TomoAlien opened this issue Apr 27, 2017 · 5 comments
Closed
Labels

Comments

@TomoAlien
Copy link

BmsONE 0.1.5 crashes when you remove a keysound while it's playing back and it's on the key lane.
This doesn't happen to keysounds located on a BGM lane.

The easiest way to reproduce it is to create/edit a note on a key lane (which will play it back), then remove it during the playback. This consistently causes a crash.

@DolphinDTM
Copy link

DolphinDTM commented Apr 27, 2017

I think this error is referenced here: #4

@excln excln added the bug label May 4, 2017
@excln
Copy link
Owner

excln commented May 9, 2017

I couldn't reproduce it on neither Windows nor Mac. Does it happen with any bmson? Is Master Cache enabled?

@TomoAlien
Copy link
Author

Yes, it happens on any bmson, and with master cache both disabled and enabled.

Here's a video of the bug in action:
https://www.youtube.com/watch?v=zu_HcGOxiRw

@excln
Copy link
Owner

excln commented May 10, 2017

OK, I finally reproduced it. It happens only on right clicking (not pressing Delete key) on the note in Write Mode regardless of the playback. It's been already fixed in the master branch. Please check the next release.

@excln
Copy link
Owner

excln commented Sep 24, 2017

Fixed at beta 0.2.1.

@excln excln closed this as completed Sep 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants