From 61d9c379718f3e7a1c72da5931a2299b9285d177 Mon Sep 17 00:00:00 2001 From: jongwhan Date: Sat, 6 Nov 2021 16:59:33 +0900 Subject: [PATCH] Problem: config/client.toml keyring-backend not working correctly (fix #724) refactoring fix lint refactoring Apply suggestions from code review add changelog --- CHANGELOG.md | 1 + client/keys.go | 6 ++---- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5fb08d4636..ef3e48aaae 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -34,6 +34,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ --> # Changelog +* (app,cli)[\#725](https://github.com/tharsis/ethermint/pull/725) different keyring-backend in adding,list keys ## Unreleased diff --git a/client/keys.go b/client/keys.go index 0569637b9f..06bc345c56 100644 --- a/client/keys.go +++ b/client/keys.go @@ -93,14 +93,12 @@ func runAddCmd(cmd *cobra.Command, args []string) error { dryRun, _ := cmd.Flags().GetBool(flags.FlagDryRun) if dryRun { kr, err = keyring.New(sdk.KeyringServiceName(), keyring.BackendMemory, clientCtx.KeyringDir, buf, hd.EthSecp256k1Option()) - } else { - backend, _ := cmd.Flags().GetString(flags.FlagKeyringBackend) - kr, err = keyring.New(sdk.KeyringServiceName(), backend, clientCtx.KeyringDir, buf, hd.EthSecp256k1Option()) + clientCtx = clientCtx.WithKeyring(kr) } if err != nil { return err } - return clientkeys.RunAddCmd(clientCtx.WithKeyring(kr), cmd, args, buf) + return clientkeys.RunAddCmd(clientCtx, cmd, args, buf) }