Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rollback packaging changes #776

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

mrexox
Copy link
Member

@mrexox mrexox commented Jul 19, 2024

Closes #775

🔧 Summary

Looks like optional dependencies (os-arch packages) conflict with the original lefthook. This was the only significant change that probably broke the behavior of npx lefthook.

The issue occured after this PR. I guess dependencies can't have the same bin name as the parent package, so npx failed to determine the right binary.

@mrexox mrexox marked this pull request as ready for review July 19, 2024 07:27
@mrexox mrexox merged commit fb6219a into evilmartians:master Jul 19, 2024
17 checks passed
@dalisoft
Copy link
Contributor

@mrexox Yes, it may cause such issue if two or more packages in same node_modules has same bin name. The solution was remove binary from main package and call binary from optional package but only architecture supported one package will be installed, so only that package could be called.

If there was full guide how to test locally or makefile/Dockerfile to test locally (automatically), i’d test.

no need for npx lefthook-{os}, enough of lefthook as lefthook binary was defined in optional package

@mrexox
Copy link
Member Author

mrexox commented Jul 29, 2024

Sounds good, so let's try one more time with "bin": "lefthook" removed from the base package?

@dalisoft
Copy link
Contributor

Yes, that was method to reduce startup time

@dalisoft dalisoft mentioned this pull request Jul 30, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

git commit command with error in macos 14.4.1 for M3.
2 participants