Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing sub directory #768

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Fix missing sub directory #768

merged 1 commit into from
Jul 11, 2024

Conversation

nikeee
Copy link
Contributor

@nikeee nikeee commented Jul 10, 2024 •
edited
Loading

Having issues after upgrading:

The application resides in a sub directory, but lefthook tires to execute the binary in the project root:

.git/hooks/pre-commit: 37: /home/$PROJECT/node_modules/lefthook-linux-x64/bin/lefthook: not found
# actual location:
# /home/$PROJECT/frontend/node_modules/lefthook-linux-x64/bin/lefthook

☑️ Checklist

  • Check locally
  • Add tests
  • Add documentation

I think it was a copy&paste error. Feel free to just close this PR if it's bogus.

@mrexox
Copy link
Member

mrexox commented Jul 11, 2024

Thank you for this finding!

@mrexox mrexox merged commit f99bcd2 into evilmartians:master Jul 11, 2024
19 checks passed
@nikeee nikeee deleted the patch-1 branch July 11, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikeee @mrexox