Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add skip option for the summary separator #570

Closed
wants to merge 1 commit into from
Closed

Add skip option for the summary separator #570

wants to merge 1 commit into from

Conversation

technicalpickles
Copy link
Contributor

@technicalpickles technicalpickles commented Nov 2, 2023 •
edited
Loading

Closes #560

⚡ Summary

Adds yet another skip option 😅 this time for the separator before a summary. I don't know if there is a point when there are too many skips, and what that point is though...

☑️ Checklist

  • Check locally
  • Add tests
  • Add documentation

@technicalpickles
Copy link
Contributor Author

Closing re #560 (comment)

What do you think if we skip summary separator when execution or execution_info and execution_out are set? Sounds like these are the only cases when summary separator is not needed

@technicalpickles technicalpickles deleted the skip-summary-separator branch November 13, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separator sometimes shown when there isn't something to separate
1 participant
@technicalpickles