lefthook install does not seem to recreate .git/hooks if it has been deleted

[technicalpickles]

🔧 Summary

I'm working on moving us from another git hook tool to lefthook, so I've been testing how the git hooks get setup so I can make sure it works consistently. In doing that, I end up doing rm -r .git/hooks quite a bit.

I would have expected lefthook install to do that, but instead it exits silently and successfully. If I do lefthook install --force, it does not recreate the files

Lefthook version

1.5.2

Steps to reproduce

• lefthook install
• configure a simple pre-commit hook:

pre-commit:
  commands:
    echo:
      run: echo echo

• lefthook install
• rm .git/hooks/*
• lefthook install

Expected results

For the last lefthook after the rm:

❯ lefthook install
sync hooks: ✔️ (pre-commit)

Actual results

❯ lefthook install

Possible Solution

I think it has to do with doing a checksum of the lefthook configuration. If I make any changes, it does seem to work as expected.

Logs / Screenshots

LEFTHOOK_VERBOSE=true git ...

[mrexox]

Hey! Lefthook uses special hashsum to determine config file changes. It stores the hashsum to .git/info/lefthook.checksum. This is useful to skip re-installing hooks every time you execute the hook because this is how lefthook knows that your config file has changed or not.

But it makes sense to sync the hooks regardless of the changes in the config just because you run it manually. I'll try to fix this next week.

[technicalpickles]

Two other datapoints:

• I wasn't able to figure out why lefthook install wasn't doing anything with LEFTHOOK_VERBOSE
• This also happens if .git/hooks is missing. I think this code could be moved up before the checksum check: https://github.com/technicalpickles/lefthook/blob/91caa53affa5ba70537ae079f6ef7d2e6cc22b40/internal/lefthook/install.go#L133-L135