fix: LEFTHOOK_VERBOSE properly overrides --verbose flag

evilmartians · Jul 14, 2023 · d205c94 · d205c94
1 parent d7b8cb7
commit d205c94
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/internal/lefthook/lefthook.go b/internal/lefthook/lefthook.go
@@ -3,6 +3,7 @@ package lefthook
 import (
 	"bufio"
 	"fmt"
+	"os"
 	"path/filepath"
 	"regexp"
 
@@ -35,6 +36,10 @@ type Lefthook struct {
 
 // New returns an instance of Lefthook.
 func initialize(opts *Options) (*Lefthook, error) {
+	if os.Getenv(envVerbose) == "1" || os.Getenv(envVerbose) == "true" {
+		opts.Verbose = true
+	}
+
 	if opts.Verbose {
 		log.SetLevel(log.DebugLevel)
 	}

diff --git a/internal/lefthook/run.go b/internal/lefthook/run.go
@@ -39,7 +39,7 @@ func (l *Lefthook) Run(hookName string, args RunArgs, gitArgs []string) error {
 	}
 
 	var verbose bool
-	if l.Verbose || os.Getenv(envVerbose) == "1" || os.Getenv(envVerbose) == "true" {
+	if l.Verbose {
 		log.SetLevel(log.DebugLevel)
 		verbose = true
 	}