From 6383ff38f936d08a70769d0fab73c6ef3eca45eb Mon Sep 17 00:00:00 2001 From: Zach Ahn Date: Thu, 26 Sep 2024 03:36:14 -0400 Subject: [PATCH] feat: skip LFS hooks when pre-push hook is skipped (#818) --- internal/lefthook/runner/runner.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/internal/lefthook/runner/runner.go b/internal/lefthook/runner/runner.go index 7579dc79..db3dce95 100644 --- a/internal/lefthook/runner/runner.go +++ b/internal/lefthook/runner/runner.go @@ -90,15 +90,15 @@ type executable interface { func (r *Runner) RunAll(ctx context.Context, sourceDirs []string) ([]Result, error) { results := make([]Result, 0, len(r.Hook.Commands)+len(r.Hook.Scripts)) - if err := r.runLFSHook(ctx); err != nil { - return results, err - } - if r.Hook.DoSkip(r.Repo.State()) { r.logSkip(r.HookName, "hook setting") return results, nil } + if err := r.runLFSHook(ctx); err != nil { + return results, err + } + if !r.DisableTTY && !r.Hook.Follow { log.StartSpinner() defer log.StopSpinner()