Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch all hex to bytes conversions to ethjs equivalents #624

Open
acolytec3 opened this issue Sep 14, 2024 · 2 comments · May be fixed by #632
Open

Switch all hex to bytes conversions to ethjs equivalents #624

acolytec3 opened this issue Sep 14, 2024 · 2 comments · May be fixed by #632
Labels
good first issue Good for newcomers

Comments

@acolytec3
Copy link
Collaborator

Now that @ethereumjs/util properly supports prefixed hex string conversions by default, we should switch all of our usage from toHexString and fromHexString (imported from @chainsafe/ssz) to bytesToHex and hexToBytes. Should be copy and paste (I hope.)
@acolytec3 acolytec3 added the good first issue Good for newcomers label Sep 14, 2024
@ScottyPoi
Copy link
Collaborator

Note that these methods use 0x prefixed hex strings.

@alivia-g
Copy link

I'll try to fix this issue : )

@alivia-g alivia-g linked a pull request Sep 25, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch all hex to bytes conversions to ethjs equivalents alivia-g/ultralight
3 participants
@acolytec3 @alivia-g @ScottyPoi