Skip to content
This repository has been archived by the owner on Dec 10, 2020. It is now read-only.

This module can't be run on a browser #40

Open
alcuadrado opened this issue Apr 22, 2019 · 4 comments
Open

This module can't be run on a browser #40

alcuadrado opened this issue Apr 22, 2019 · 4 comments

Comments

@alcuadrado
Copy link
Member

While working on ethereumjs/ethereumjs-tx#145 I got convinced that this module can't be run in a browser anymore.

Previously, this module used bulk-require and bulkify to read the tests fixtures. Both were created by substack (browserify author) to work nicely with browserify.

Now we are using node-dir, which doesn't seem to work with browserify.

@holgerd77
Copy link
Member

Hmm, it's a bit annoying, but maybe we should do a simple Karma setup on the library here itself? ethereumjs-testing is just internal, but the potential to break stuff is nevertheless there.

@alcuadrado
Copy link
Member Author

I'm not sure what you mean. Do you mean running this module's tests with karma?

@holgerd77
Copy link
Member

Yes. Does this make sense or is it over the top?

@alcuadrado
Copy link
Member Author

Makes sense. It will force this library to be browser-compatible.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants