You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 6, 2020. It is now read-only.
I just noticed that this lib is using a static fixture, i.e. not tests from ethereumjs-testing and the last commit of that file is in May 2018. I'm not sure if any HF since then has directly touched Blockchain's code, but at least in future it's possible.
The file seems to have been taken from the BlockchainTests suite, but many of the values are hardcoded in the unit tests. Ideally we should make this a bit more flexible and upgrade-able.
The text was updated successfully, but these errors were encountered:
Also for reference: we should minimally also introduce some JSON metadata test file format with info like "source", "version", "commit" and "date" like being done here for the RLP library.
I just noticed that this lib is using a static fixture, i.e. not tests from
ethereumjs-testing
and the last commit of that file is in May 2018. I'm not sure if any HF since then has directly touched Blockchain's code, but at least in future it's possible.The file seems to have been taken from the
BlockchainTests
suite, but many of the values are hardcoded in the unit tests. Ideally we should make this a bit more flexible and upgrade-able.The text was updated successfully, but these errors were encountered: