Skip to content
This repository has been archived by the owner on Apr 6, 2020. It is now read-only.

Make sure test fixture is not outdated #132

Closed
s1na opened this issue Nov 27, 2019 · 2 comments
Closed

Make sure test fixture is not outdated #132

s1na opened this issue Nov 27, 2019 · 2 comments

Comments

@s1na
Copy link
Contributor

s1na commented Nov 27, 2019

I just noticed that this lib is using a static fixture, i.e. not tests from ethereumjs-testing and the last commit of that file is in May 2018. I'm not sure if any HF since then has directly touched Blockchain's code, but at least in future it's possible.

The file seems to have been taken from the BlockchainTests suite, but many of the values are hardcoded in the unit tests. Ideally we should make this a bit more flexible and upgrade-able.

@holgerd77
Copy link
Member

Also for reference: we should minimally also introduce some JSON metadata test file format with info like "source", "version", "commit" and "date" like being done here for the RLP library.

@ryanio
Copy link
Contributor

ryanio commented Dec 16, 2019

Fixed with #134

@ryanio ryanio closed this as completed Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants