Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect error checking in SyncingWithInvalidChain test #739

Closed
Tumas opened this issue Mar 8, 2023 · 0 comments · Fixed by #897
Closed

Incorrect error checking in SyncingWithInvalidChain test #739

Tumas opened this issue Mar 8, 2023 · 0 comments · Fixed by #897
Assignees

Comments

@Tumas
Copy link

Tumas commented Mar 8, 2023

It looks like this error checking condition is incorrect and needs to be inverted:

if payload, err := versionedBlock.ExecutionPayload(); err == nil {
t.Fatalf(
"FAIL: error getting execution payload: %v",
err,
)

as ExecutionPayload method returns no error when payload is returned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants