From af48987c21ed95a14508170e0391c134c6c2a12b Mon Sep 17 00:00:00 2001 From: George Kadianakis Date: Wed, 2 Nov 2022 12:20:26 +0200 Subject: [PATCH] Minor spec improvements (after review by hww) --- setup.py | 2 +- specs/eip4844/polynomial-commitments.md | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/setup.py b/setup.py index 38b651315c..f3f4c87fc4 100644 --- a/setup.py +++ b/setup.py @@ -616,7 +616,7 @@ def sundry_functions(cls) -> str: ROOTS_OF_UNITY = kzg.compute_roots_of_unity(TESTING_FIELD_ELEMENTS_PER_BLOB) -def retrieve_blobs_sidecar(slot: Slot, beacon_block_root: Root) -> BlobsSidecar: +def retrieve_blobs_sidecar(slot: Slot, beacon_block_root: Root) -> Optional[BlobsSidecar]: return "TEST"''' @classmethod diff --git a/specs/eip4844/polynomial-commitments.md b/specs/eip4844/polynomial-commitments.md index 0fc255fa98..be36d8f53b 100644 --- a/specs/eip4844/polynomial-commitments.md +++ b/specs/eip4844/polynomial-commitments.md @@ -152,12 +152,12 @@ def blob_to_polynomial(blob: Blob) -> Polynomial: """ Convert a blob to list of BLS field scalars. """ - r = Polynomial() + polynomial = Polynomial() for i in range(FIELD_ELEMENTS_PER_BLOB): value = int.from_bytes(blob[i * BYTES_PER_FIELD_ELEMENT: (i + 1) * BYTES_PER_FIELD_ELEMENT], ENDIANNESS) assert value < BLS_MODULUS - r[i] = value - return r + polynomial[i] = value + return polynomial ``` #### `hash_to_bls_field` @@ -178,9 +178,9 @@ def hash_to_bls_field(polys: Sequence[Polynomial], # Append each polynomial which is composed by field elements for poly in polys: for field_element in poly: - data += int.to_bytes(field_element, 32, ENDIANNESS) + data += int.to_bytes(field_element, BYTES_PER_FIELD_ELEMENT, ENDIANNESS) - # Append serialised G1 points + # Append serialized G1 points for commitment in comms: data += commitment