Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Replace t.error/fatal with assert/request in [raft_paper_test.go] #182

Merged

Conversation

MrDXY
Copy link
Contributor

@MrDXY MrDXY commented Mar 11, 2024

Refactor: Replacing t.Error/t.Fatal with assert/require

This commit tries to eliminate boilerplate code in the testing suite by replacing occurrences
of t.Error and t.Fatal with assertions from the assert and require packages.

Changes Made:

  • Replaced instances of t.Error with assert
  • Replaced instances of t.Fatal with require

Affected Files:

  • [raft_paper_test.go]

Part of: #146

@MrDXY MrDXY mentioned this pull request Mar 11, 2024
6 tasks
Copy link
Contributor

@pav-kv pav-kv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % some suggestions

raft_paper_test.go Outdated Show resolved Hide resolved
assert.Equal(t, uint64(2), r.Term)
assert.Equal(t, StateCandidate, r.state)
assert.True(t, r.trk.Votes[r.id])

msgs := r.readMessages()
sort.Sort(messageSlice(msgs))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For another PR: consider removing messageSlice, and using slices.SortFunc with some stable comparator.

Copy link
Contributor Author

@MrDXY MrDXY Mar 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be what you had in mind?

slices.SortStableFunc(data, orderMessageAsc)
func sortMessageAsc(a pb.Message, b pb.Message) int {
	strA := fmt.Sprint(a)
	strB := fmt.Sprint(b)
	if strA > strB {
		return 1
	} else if strA < strB {
		return -1
	} else {
		return 0
	}
}

Signed-off-by: Xinyuan Du <xinyuandu@bupt.cn>
@MrDXY MrDXY force-pushed the replace-test-errors-with-assert-(raft_paper_test.go) branch from 34fe5ef to 7f0764c Compare March 11, 2024 15:30
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Thanks

@ahrtr ahrtr merged commit a76fbc0 into etcd-io:main Mar 12, 2024
10 checks passed
@MrDXY MrDXY deleted the replace-test-errors-with-assert-(raft_paper_test.go) branch April 7, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants