Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bucket.Put: copy key before seek #637

Merged
merged 3 commits into from
Dec 13, 2023
Merged

bucket.Put: copy key before seek #637

merged 3 commits into from
Dec 13, 2023

Commits on Dec 13, 2023

  1. *: introduce failpoint beforeBucketPut 

    Signed-off-by: Wei Fu <fuweid89@gmail.com>
    @fuweid
    fuweid committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    324df9c View commit details
    Browse the repository at this point in the history

  2. tests/robustness: add issue72 reproducer 

    Signed-off-by: Wei Fu <fuweid89@gmail.com>
    @fuweid
    fuweid committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    1b08078 View commit details
    Browse the repository at this point in the history

  3. bucket: copy key before Put 

    Application might change key value after seeking and before real put.
This unexpected behaviour could corrupt database. When users file issue,
maintainers doesn't know application behaviour. It could be caused by
data race. This patch is to prevent such case and save maintainers' time.

Signed-off-by: Wei Fu <fuweid89@gmail.com>
    @fuweid
    fuweid committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    a05ec68 View commit details
    Browse the repository at this point in the history