Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[voice_kit] add yaml configuration options for pipeline stage #132

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

kahrendt
Copy link
Collaborator

Adds channel_0_stage and channel_1_stage yaml configuration options. It changes the default channel 1 stage to use AEC+IC+Noise Suppression

I'm not sure how to best approach this, to keep the stage the component holds in sync with the stage on the XMOS. Write now I have a basic setter that the codegen stage uses. On boot, if the XMOS firmware doesn't need updating, it will write them to the XMOS using write_pipeline_stages(). If the firmware updates, it will wait until its successful before calling that function. I'm open to any better approaches!

@kahrendt kahrendt requested a review from kbx81 September 19, 2024 15:27
Copy link

Firmware built successfully! 🎉

Download and extract the firmware to install with https://web.esphome.io

Make sure to choose home-assistant-voice-esp32s3.factory.bin.

@kbx81
Copy link
Member

kbx81 commented Sep 19, 2024

LGTM! Should we include an action to set this during runtime, in addition to what you've added to the base component?

@kahrendt
Copy link
Collaborator Author

LGTM! Should we include an action to set this during runtime, in addition to what you've added to the base component?

I don't think we need to expose an action, these settings probably won't change ever beyond the configuration stage. For experimenting, I think using a lambda action to change is sufficient.

@synesthesiam
Copy link
Collaborator

Looks good to me! I haven't tested it yet though.

@kahrendt kahrendt enabled auto-merge (squash) September 20, 2024 10:28
@kahrendt kahrendt force-pushed the kahrendt-20240919-pipeline-stage-in-yaml branch from e9765e2 to 71a3d39 Compare September 20, 2024 10:28
@kahrendt kahrendt enabled auto-merge (squash) September 20, 2024 10:29
@kahrendt kahrendt merged commit 7ed2820 into dev Sep 20, 2024
3 checks passed
@kahrendt kahrendt deleted the kahrendt-20240919-pipeline-stage-in-yaml branch September 20, 2024 10:37
Copy link

Firmware built successfully! 🎉

Download and extract the firmware to install with https://web.esphome.io

Make sure to choose home-assistant-voice-esp32s3.factory.bin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants