From 977825d50006e6b70e206d2e79e4e17e812bc2a3 Mon Sep 17 00:00:00 2001 From: Lauren Yim <31467609+cherryblossom000@users.noreply.github.com> Date: Mon, 21 Aug 2023 13:00:25 +1000 Subject: [PATCH 1/3] docs: improve wording of file-extension-in-import docs https://github.com/mysticatea/eslint-plugin-node/pull/325 --- docs/rules/file-extension-in-import.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/rules/file-extension-in-import.md b/docs/rules/file-extension-in-import.md index cfec2f36..a1a1d4e2 100644 --- a/docs/rules/file-extension-in-import.md +++ b/docs/rules/file-extension-in-import.md @@ -11,9 +11,9 @@ import foo from "./path/to/a/file" // maybe it's resolved to 'file.js' or 'file. export * from "./path/to/a/file" ``` -However, [--experimental-modules](https://medium.com/@nodejs/announcing-a-new-experimental-modules-1be8d2d6c2ff) has declared to drop the file extension omition. +However, when using [`--experimental-modules`](https://medium.com/@nodejs/announcing-a-new-experimental-modules-1be8d2d6c2ff), file extensions are required. -Also, we can import a variety kind of files with bundlers such as Webpack. In the situation, probably explicit file extensions help us to understand code. +We can also import a variety of file types with bundlers such as Webpack. In this situation, explicit file extensions can help to identify the type of file being imported. ## 📖 Rule Details From d367a067c3067d57a82cbd4917266d21e6dd7e9e Mon Sep 17 00:00:00 2001 From: Sebastian Good <2230835+scagood@users.noreply.github.com> Date: Thu, 22 Feb 2024 09:58:49 +0000 Subject: [PATCH 2/3] Update docs/rules/file-extension-in-import.md --- docs/rules/file-extension-in-import.md | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/rules/file-extension-in-import.md b/docs/rules/file-extension-in-import.md index a1a1d4e2..ae6420fe 100644 --- a/docs/rules/file-extension-in-import.md +++ b/docs/rules/file-extension-in-import.md @@ -11,7 +11,6 @@ import foo from "./path/to/a/file" // maybe it's resolved to 'file.js' or 'file. export * from "./path/to/a/file" ``` -However, when using [`--experimental-modules`](https://medium.com/@nodejs/announcing-a-new-experimental-modules-1be8d2d6c2ff), file extensions are required. We can also import a variety of file types with bundlers such as Webpack. In this situation, explicit file extensions can help to identify the type of file being imported. From 3bbee59e1ce285fd494940a5948fb663a0aeb549 Mon Sep 17 00:00:00 2001 From: Sebastian Good <2230835+scagood@users.noreply.github.com> Date: Thu, 22 Feb 2024 10:00:19 +0000 Subject: [PATCH 3/3] docs: Remove multiple blank lines --- docs/rules/file-extension-in-import.md | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/rules/file-extension-in-import.md b/docs/rules/file-extension-in-import.md index ae6420fe..c506546f 100644 --- a/docs/rules/file-extension-in-import.md +++ b/docs/rules/file-extension-in-import.md @@ -11,7 +11,6 @@ import foo from "./path/to/a/file" // maybe it's resolved to 'file.js' or 'file. export * from "./path/to/a/file" ``` - We can also import a variety of file types with bundlers such as Webpack. In this situation, explicit file extensions can help to identify the type of file being imported. ## 📖 Rule Details