From 2672a3b1a4bd38a64ab0800ea14a5b73ed6a7b1e Mon Sep 17 00:00:00 2001 From: ddl Date: Tue, 5 Dec 2023 12:23:36 +0800 Subject: [PATCH 1/2] clean todo --- README.md | 3 --- docs/mining.md | 3 --- 2 files changed, 6 deletions(-) diff --git a/README.md b/README.md index 248de8df720..4c49aa587f1 100644 --- a/README.md +++ b/README.md @@ -197,9 +197,6 @@ Support only remote-miners. * TODO: + we don't broadcast mined blocks to p2p-network yet, [but it's easy to accomplish](https://github.com/ledgerwatch/erigon/blob/9b8cdc0f2289a7cef78218a15043de5bdff4465e/eth/downloader/downloader.go#L673) - + eth_newPendingTransactionFilter - + eth_newBlockFilter - + eth_newFilter + websocket Logs 🔬 Detailed explanation is [here](/docs/mining.md). diff --git a/docs/mining.md b/docs/mining.md index c85333f857a..7464d0aff5b 100644 --- a/docs/mining.md +++ b/docs/mining.md @@ -27,7 +27,4 @@ to `integration state_stages` command: * TODO: + we don't broadcast mined blocks to p2p-network yet, [but it's easy to accomplish](https://github.com/ledgerwatch/erigon/blob/9b8cdc0f2289a7cef78218a15043de5bdff4465e/eth/downloader/downloader.go#L673) - + eth_newPendingTransactionFilter - + eth_newBlockFilter - + eth_newFilter + websocket Logs From e7ce957e8c9b858e03c67040b0c784c17670ce86 Mon Sep 17 00:00:00 2001 From: ddl Date: Tue, 5 Dec 2023 23:44:42 +0800 Subject: [PATCH 2/2] chore: update outdated information --- README.md | 5 +---- docs/mining.md | 4 ---- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/README.md b/README.md index 4c49aa587f1..7ada8d94f97 100644 --- a/README.md +++ b/README.md @@ -194,10 +194,7 @@ Support only remote-miners. , `--miner.gastarget` * JSON-RPC supports methods: eth_coinbase , eth_hashrate, eth_mining, eth_getWork, eth_submitWork, eth_submitHashrate * JSON-RPC supports websocket methods: newPendingTransaction -* TODO: - + we don't broadcast mined blocks to p2p-network - yet, [but it's easy to accomplish](https://github.com/ledgerwatch/erigon/blob/9b8cdc0f2289a7cef78218a15043de5bdff4465e/eth/downloader/downloader.go#L673) - + websocket Logs + 🔬 Detailed explanation is [here](/docs/mining.md). diff --git a/docs/mining.md b/docs/mining.md index 7464d0aff5b..c84a4013fb2 100644 --- a/docs/mining.md +++ b/docs/mining.md @@ -24,7 +24,3 @@ to `integration state_stages` command: ``` ./build/bin/integration state_stages --datadir= --unwind=1 --unwind.every=2 --integrity.fast=false --integrity.slow=false --mine --miner.etherbase= ``` - -* TODO: - + we don't broadcast mined blocks to p2p-network yet, [but it's easy to accomplish](https://github.com/ledgerwatch/erigon/blob/9b8cdc0f2289a7cef78218a15043de5bdff4465e/eth/downloader/downloader.go#L673) - + websocket Logs