Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use another dataset for tests and notebooks #194

Closed
3 tasks done
eonu opened this issue Jun 9, 2022 · 1 comment
Closed
3 tasks done

Use another dataset for tests and notebooks #194

eonu opened this issue Jun 9, 2022 · 1 comment
Labels
enhancement New feature or request priority: 3

Comments

@eonu
Copy link
Owner

eonu commented Jun 9, 2022

Tests currently rely on small simple datasets that aren't really representative of even a simple real-world dataset.

Notebooks rely on TorchFSDD which is a good dataset, but requires installation of torch in order to run tests. This can be an issue in terms of compatibility on some devices, and we can get away with a simpler dataset.

Perhaps the solution to both of these problems is #141.

Note: Make sure to fix the tests that were skipped in #201. Also examples on RTD need to be updated.


@eonu
Copy link
Owner Author

eonu commented Jun 26, 2022

Fixed in #217.

@eonu eonu closed this as completed Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: 3
Projects
None yet
Development

No branches or pull requests

1 participant