Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: return 500 when BackendTLSPolicy translation fails #4363

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

alexwo
Copy link
Contributor

@alexwo alexwo commented Sep 29, 2024

What type of PR is this?

What this PR does / why we need it:
Return 500 when BackendTLSPolicy translation fails

Which issue(s) this PR fixes:
Fixes #4087

Signed-off-by: Alexander Volchok <alex.volchok@sap.com>
Signed-off-by: Alexander Volchok <alex.volchok@sap.com>
@alexwo alexwo requested a review from a team as a code owner September 29, 2024 12:20
@alexwo alexwo changed the title return 500 when backtls policy config fails Return 500 when BackendTLSPolicy translation fails #4087 Sep 29, 2024
@zirain zirain changed the title Return 500 when BackendTLSPolicy translation fails #4087 bugfix: return 500 when BackendTLSPolicy translation fails Sep 29, 2024
@alexwo alexwo changed the title bugfix: return 500 when BackendTLSPolicy translation fails refactor: return 500 when BackendTLSPolicy translation fails Sep 29, 2024
Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 73.41772% with 21 lines in your changes missing coverage. Please review.

Project coverage is 65.96%. Comparing base (b91f296) to head (75d8e12).

Files with missing lines Patch % Lines
internal/gatewayapi/route.go 70.00% 8 Missing and 4 partials ⚠️
internal/gatewayapi/filters.go 62.50% 5 Missing and 1 partial ⚠️
internal/gatewayapi/ext_service.go 50.00% 1 Missing and 1 partial ⚠️
internal/gatewayapi/backendtlspolicy.go 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4363      +/-   ##
==========================================
- Coverage   66.04%   65.96%   -0.09%     
==========================================
  Files         200      200              
  Lines       24052    24084      +32     
==========================================
+ Hits        15886    15887       +1     
- Misses       7036     7057      +21     
- Partials     1130     1140      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Alexander Volchok <alex.volchok@sap.com>
Signed-off-by: Alexander Volchok <alex.volchok@sap.com>
@alexwo
Copy link
Contributor Author

alexwo commented Sep 29, 2024

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return 500 when BackendTLSPolicy translation fails
1 participant