Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix receivers & check ResourceRender implements. #4344

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

qicz
Copy link
Member

@qicz qicz commented Sep 27, 2024

Signed-off-by: qicz <qiczzhu@gmail.com>
@qicz qicz requested a review from a team as a code owner September 27, 2024 05:26
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 18.18182% with 9 lines in your changes missing coverage. Please review.

Project coverage is 66.00%. Comparing base (b91f296) to head (a246c29).

Files with missing lines Patch % Lines
internal/ir/xds.go 28.57% 5 Missing ⚠️
internal/ir/infra.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4344      +/-   ##
==========================================
- Coverage   66.04%   66.00%   -0.05%     
==========================================
  Files         200      200              
  Lines       24052    24052              
==========================================
- Hits        15886    15875      -11     
- Misses       7036     7044       +8     
- Partials     1130     1133       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: qicz <qiczzhu@gmail.com>
@qicz qicz requested a review from zirain September 29, 2024 14:07
Signed-off-by: qicz <qiczzhu@gmail.com>
@qicz
Copy link
Member Author

qicz commented Sep 29, 2024

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants