-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] 1.4.0 introduces "global is not defined" #218
Comments
The problem is that doing a major doesn't really help you. Only one copy of ember-auto-import is allowed to win, and if the app has one, it will be that one. So as soon as apps upgrade, ember-intl would break again in the same way. I do consider #216 a bugfix. Automatically polyfilling node behaviors for the browser was never intentional. I agree that the situation with webpack configs is not ideal. Unfortunately they don't compose well, and most settings are extremely global in nature. So it's hard for addons to change settings without having big side effects. But that is why I think it's so important to have defaults that try to adhere as closely as possible to web standards, without sneaking in implementation-defined things like webpack's polyfills. Thankfully |
Ah, I forgot about the single add-on limitation. Embroider won't suffer from this, correct? It sounds like a one off polyfill then is more reliable solution then modifying the unified webpack config. Thanks a ton for the quick response, feel free to close. |
As of 1.4.0, Webpack no longer is polyfilling
global
.This was spotted in my CI pipeline for ember-intl. Other users also reported seeing this on other libs that
ember-auto-import
bundles i.e,auth0-lock
.I believe the issue was introduced here: #216
If
node: false
is recommended then I'd suggest a new major version and reverted for 1.x branch.A workaround for now:
ember-intl/ember-intl@f0419f2#diff-168726dbe96b3ce427e7fedce31bb0bc
The text was updated successfully, but these errors were encountered: