From 8a42b3b08f78ccb1c7bb69a6b13adef10b762e95 Mon Sep 17 00:00:00 2001 From: Dan Monroe Date: Sun, 3 Feb 2019 13:50:59 -0500 Subject: [PATCH] [DOC lts] Addressed PR comments (cherry picked from commit 5c9b6e1c3b97c977e10d503c2cb14a929fc3534a) --- packages/@ember/-internals/glimmer/lib/component.ts | 8 ++++++-- .../@ember/-internals/glimmer/lib/helpers/component.ts | 3 ++- .../@ember/-internals/glimmer/lib/helpers/if-unless.ts | 10 ++++++++-- packages/@ember/-internals/glimmer/lib/helpers/mut.ts | 5 +++++ 4 files changed, 21 insertions(+), 5 deletions(-) diff --git a/packages/@ember/-internals/glimmer/lib/component.ts b/packages/@ember/-internals/glimmer/lib/component.ts index c7f0ec7c5a4..d661970ff29 100644 --- a/packages/@ember/-internals/glimmer/lib/component.ts +++ b/packages/@ember/-internals/glimmer/lib/component.ts @@ -45,10 +45,11 @@ export const BOUNDS = symbol('BOUNDS'); ```app/templates/components/my-foo.hbs ``` + or ```app/templates/components/my-foo.hbs - {{person-profile person=currentUser}} + {{person-profile person=this.currentUser}} ``` ```app/templates/components/person-profile.hbs @@ -68,9 +69,10 @@ export const BOUNDS = symbol('BOUNDS'); {{! Executed in the controller's context. }} ``` + or ```handlebars - {{#person-profile person=currentUser}} + {{#person-profile person=this.currentUser}}

Admin mode

{{! Executed in the controller's context. }} {{/person-profile}} @@ -474,7 +476,9 @@ export const BOUNDS = symbol('BOUNDS');

Fisherman Industries

``` + or + ```handlebars {{#person-profile}}

Chief Basket Weaver

diff --git a/packages/@ember/-internals/glimmer/lib/helpers/component.ts b/packages/@ember/-internals/glimmer/lib/helpers/component.ts index e89c7bb0cf9..34bffad8dc5 100644 --- a/packages/@ember/-internals/glimmer/lib/helpers/component.ts +++ b/packages/@ember/-internals/glimmer/lib/helpers/component.ts @@ -112,9 +112,10 @@ ``` - {{form.nameInput placeholder="Username"}} + ``` + or ``` {{#person-form as |form|}} diff --git a/packages/@ember/-internals/glimmer/lib/helpers/if-unless.ts b/packages/@ember/-internals/glimmer/lib/helpers/if-unless.ts index 6195967ffd7..9f4d95b1c73 100644 --- a/packages/@ember/-internals/glimmer/lib/helpers/if-unless.ts +++ b/packages/@ember/-internals/glimmer/lib/helpers/if-unless.ts @@ -118,8 +118,11 @@ class ConditionalHelperReference extends CachedReference { You can use the `if` helper inside another helper as a nested helper: ```handlebars - + ``` + + or + ```handlebars {{some-component height=(if isBig "100" "10")}} ``` @@ -154,8 +157,11 @@ export function inlineIf(_vm: VM, { positional }: Arguments) { You can use the `unless` helper inside another helper as a subexpression. ```handlebars - + ``` + + or + ```handlebars {{some-component height=(unless isBig "10" "100")}} ``` diff --git a/packages/@ember/-internals/glimmer/lib/helpers/mut.ts b/packages/@ember/-internals/glimmer/lib/helpers/mut.ts index 12f72fdd32c..8b3f17ac0eb 100644 --- a/packages/@ember/-internals/glimmer/lib/helpers/mut.ts +++ b/packages/@ember/-internals/glimmer/lib/helpers/mut.ts @@ -15,6 +15,9 @@ import { INVOKE, UPDATE } from '../utils/references'; ```handlebars ``` + + or + ```handlebars {{my-child childClickCount=(mut totalClicks)}} ``` @@ -40,7 +43,9 @@ import { INVOKE, UPDATE } from '../utils/references'; ```handlebars ``` + or + ```handlebars {{my-child childClickCount=totalClicks click-count-change=(action (mut totalClicks))}} ```