fix(formatter): fix small issue where there was only one newline added #13867
+60
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to a def that is followed by a module attribute.
josevalim
reviewed
Sep 28, 2024
| @@ -656,6 +656,14 @@ defmodule Code.Formatter do | |||
| defp block_next_line(:@), do: @empty | |||
| defp block_next_line(_), do: break("") | |||
|
|
|||
| defp maybe_add_newlines({:def, [{:@, _, _} = _next | _]}, _meta) do | |||
There was a problem hiding this comment.
We should not look at def, because we can have def, defp, defmacro, defmacrop... and projects can define defn, defnp, etc. We do have some code today that skips adding new lines if they are module attributes but perhaps the code should only avoid adding lines below, not lines up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to a def that is followed by a module attribute.
Closes #13866
I'm not sure this implementation is the best, but it seems to do the job. I wouldn't be surprised if there is a better way to solve it though. This was my naive approach.
The test cases show the current behavior (def + def works, but def + mod attr doesn't).
Feel free to adjust/modify/close/do whatever you'd like to it if you see it fit.
Thank you for all of your work as usual! ❤️