Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve upload artifact to builds.hex.pm workflow #13845

Open
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

wingyplus
Copy link
Contributor

@wingyplus wingyplus commented Sep 20, 2024

In this changeset, I changed the upload workflow to upload after we built the release artifact. So the flow will be changed to:

Screenshot 2024-09-20 235624

You can see the demo at https://github.com/wingyplus/elixir/actions/runs/11056313905.

The pros of this way is we have only a single workflow, can reuse all both nightly (main) and release (v*) versions.

I have a few tasks left to unlock the draft:

  • Uncomment Fastly flush cache. I cannot test this step by myself because I have no Fastly setup. :(
  • Make update builds.txt works.
  • Remove builds.hex.pm.yml

Before continue those tasks above, is this PR ok for you?

Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
@wojtekmach
Copy link
Member

@wingyplus yup, the direction looks good to me!

@wojtekmach
Copy link
Member

Uncomment Fastly flush cache. I cannot test this step by myself because I have no Fastly setup. :(

If it's easy enough to move that into a separate step, perhaps guarding it like the following will help you?

name: Flush Fastly cache
if: github.repository == 'elixir-lang/elixir'
run: |
  ...

Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
@wingyplus wingyplus marked this pull request as ready for review September 25, 2024 18:00
@wingyplus
Copy link
Contributor Author

@wojtekmach The PR is ready to review now. 🙏

Uncomment Fastly flush cache. I cannot test this step by myself because I have no Fastly setup. :(

If it's easy enough to move that into a separate step, perhaps guarding it like the following will help you?

name: Flush Fastly cache
if: github.repository == 'elixir-lang/elixir'
run: |
  ...

That's a good idea. I will try it tomorrow. 👍

Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
@wingyplus
Copy link
Contributor Author

wingyplus commented Sep 26, 2024

@wojtekmach The PR is ready to review now. 🙏

Uncomment Fastly flush cache. I cannot test this step by myself because I have no Fastly setup. :(

If it's easy enough to move that into a separate step, perhaps guarding it like the following will help you?

name: Flush Fastly cache
if: github.repository == 'elixir-lang/elixir'
run: |
  ...

That's a good idea. I will try it tomorrow. 👍

Done! Here is the demo https://github.com/wingyplus/elixir/actions/runs/11056148036/job/30717118796. The flush cache disabled because of if guard.

Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants